Opened 9 years ago

Closed 6 years ago

#2832 closed enhancement (fixed)

Render tourism=picnic_site, leisure=picnic_table

Reported by: jesh Owned by: mapnik-team@…
Priority: minor Milestone:
Component: mapnik Version:
Keywords: tourism, picnic, picnic_site Cc:

Description

Picnic sites are not currently rendered; it would be nice if they would be on the map. They probably should only be shown on last couple of zoom layers, maybe from 16 or 17.

http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dpicnic_site

Change History (6)

comment:1 Changed 9 years ago by steve8@…

Could you give a couple of sample URLs and I will have a look

comment:2 Changed 9 years ago by steve8@…

Resolution: fixed
Status: newclosed

Included in r23653

comment:3 Changed 9 years ago by jesh

Resolution: fixed
Status: closedreopened

Thanks for the fix, but it seems to me that amenity=picnic_site gets rendered now, but not tourism=picnic_site. Could you re-check the fix? It is supposed to be tourism, not amenity, that gets rendered.

http://taginfo.openstreetmap.de/tags/tourism=picnic_site

(and sorry for not commenting earlier)

comment:4 Changed 7 years ago by naught101

Summary: Render tourism=picnic_siteRender tourism=picnic_site, leisure=picnic_table

There is good testing data here: http://www.openstreetmap.org/?lat=-32.941254&lon=151.767866&zoom=18&layers=M

I used at least one combination of each of the keys "tourism", "leisure" and "amenity", and the values "picnic_table" and "picnic_site".

In Mapnik, the only combination that currently renders is "amenity=picnic_site". In JOSM, the only combination that renders is "tourism=picnic_site"

Would definitely be good to standardise. It would probably also be good to have separate definitions for picnic_site and picnic_table. See the wiki pages: https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dpicnic_site https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dpicnic_table They seems like appropriate tags to me. I would suggest that a tourism=picnic_site is something larger, like a tourist attraction, that can be viewed at zoom levels 16 and above (this is the behaviour of amenity=picnic_site at the moment), and that leisure=picnic_table displays the same, but is only visible at zoom level 18, as such tables are often close together.

comment:5 Changed 7 years ago by naught101

comment:6 Changed 6 years ago by clockwerx

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.