Opened 9 years ago

Closed 5 years ago

#2873 closed enhancement (worksforme)

[landcover] surface=sand

Reported by: John Owned by: mapnik-team@…
Priority: trivial Milestone:
Component: mapnik Version:
Keywords: Cc:

Description

Please render natural=sand the same as natural=beach

Change History (11)

comment:1 Changed 9 years ago by John

Summary: natural=sandsurface=sand

After further comments on the tagging list it should be surface=sand.

comment:2 in reply to:  1 ; Changed 8 years ago by dieterdreist

Replying to JohnSmith:

After further comments on the tagging list it should be surface=sand.

After further comments on the tagging list this should be landcover=sand.

comment:3 in reply to:  2 Changed 8 years ago by John

Replying to dieterdreist:

Replying to JohnSmith:

After further comments on the tagging list it should be surface=sand.

After further comments on the tagging list this should be landcover=sand.

Why should it, so far no one has shown how landcover=* is better, in fact it just makes things worst because it ends up duplicating surface=* for no good reason and surface=* is widely used already.

comment:4 in reply to:  2 ; Changed 8 years ago by Ldp

Replying to dieterdreist:

Replying to JohnSmith:

After further comments on the tagging list it should be surface=sand.

After further comments on the tagging list this should be landcover=sand.

After further comments off list we're now rendering natural=sand.

comment:5 in reply to:  4 Changed 8 years ago by John

Replying to Ldp:

Replying to dieterdreist:

Replying to JohnSmith:

After further comments on the tagging list it should be surface=sand.

After further comments on the tagging list this should be landcover=sand.

After further comments off list we're now rendering natural=sand.

And this is why this bug was filed, natural=sand might be ok for a beach, however it doesn't fit for things like beach volleyball courts and golf bunkers.

comment:6 Changed 8 years ago by Ldp

You're right. For those you would use, in order:

  • natural=beach (+ surface=sand)
  • leisure=pitch + sport=beachvolleybal (+ surface=sand)
  • sport=golf (+ surface=sand) + .... well, I don't know what this month's flavour of golf tagging (for a bunker) is.

In short, surface is regarded as a supporting tag, giving extra information. It is not a main tag in and of itself. We can't render surface=sand as-is, without there being a main tag to say what feature has a sand surface. And even then, we're likely to just render that main tag, not taking any surface=* into account.

comment:7 in reply to:  6 Changed 8 years ago by John

Replying to Ldp:

You're right. For those you would use, in order:

  • natural=beach (+ surface=sand)
  • leisure=pitch + sport=beachvolleybal (+ surface=sand)
  • sport=golf (+ surface=sand) + .... well, I don't know what this month's flavour of golf tagging (for a bunker) is.

In short, surface is regarded as a supporting tag, giving extra information. It is not a main tag in and of itself. We can't render surface=sand as-is, without there being a main tag to say what feature has a sand surface. And even then, we're likely to just render that main tag, not taking any surface=* into account.

Why does it matter what the main tag is, any area with surface=sand just needs to be a yellowish colour then you don't need to know/care what the main tag is, and it will still render.

comment:8 Changed 8 years ago by dieterdreist

IMHO surface=sand will not work on natural=beach, because there will also be buildings and paved areas on beaches, which are not surface sand, but still they are on the beach (so natural=beach will include the buildings and paved areas, surface=sand won't).

comment:9 in reply to:  8 Changed 8 years ago by John

Replying to dieterdreist:

IMHO surface=sand will not work on natural=beach, because there will also be buildings and paved areas on beaches, which are not surface sand, but still they are on the beach (so natural=beach will include the buildings and paved areas, surface=sand won't).

That's grasping at straws, since overlapping polygons is already solved. Assuming of course that the polygons overlap.

comment:10 Changed 5 years ago by math1985

Summary: surface=sand[landcover] surface=sand

comment:11 Changed 5 years ago by math1985

Resolution: worksforme
Status: newclosed

This has been resolved in the meanwhile.

Note: See TracTickets for help on using tickets.