Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

[PATCH] advanced multipolygon name rendering issues #2904

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

[PATCH] advanced multipolygon name rendering issues #2904

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Irrfahrt
[Submitted to the original trac issue database at 9.37pm, Tuesday, 20th April 2010]

Osmarender (orp.pl) overwrites tags given to a multipolygon by copying all tags data from its outer ways to the multipolygon itself. Thereby it doesn't honor already assigned tag keys. Which results in e.g. a wrong nameing of the multipolygon and a bad placement of the name label (in zoom level 17). See [http://img217.imageshack.us/img217/825/unpatched.png unpatched.png] - the name of the place is actually the name of the street.

The attached patch fixes this by not copying any tag data from outer ways to an advanced multipolygon. In case of a simple multipolygon (only one outer way), it copies only that data from the outer way that isn't yet assigned to the multipolygon, without touching present tag data.
See [http://img9.imageshack.us/img9/900/patched.png patched.png] - the place is now named right and the label is placed over the multipolygon's center.

@openstreetmap-trac
Copy link
Author

Author: Irrfahrt
[Added to the original trac issue at 11.17pm, Sunday, 25th April 2010]

Enhanced the patch to be less strict and introduced a compatibility mode for multipolygon relations following older tagging rules.

@openstreetmap-trac
Copy link
Author

Author: osm[at]petschge.de
[Added to the original trac issue at 10.40am, Thursday, 13th May 2010]

Applied in r21256. I'll close this ticket for now. Please reopen if you have a patch for or/xml or if the patch for or/p creates any problems for you.

@openstreetmap-trac
Copy link
Author

Author: petschge
[Added to the original trac issue at 9.46am, Saturday, 15th May 2010]

(In [21278]) Update patch by Irrfahrt commited in r21256. Should finally fix #2904.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant