Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2904 closed defect (fixed)

[PATCH] advanced multipolygon name rendering issues

Reported by: Irrfahrt Owned by: osm@…
Priority: major Milestone:
Component: osmarender Version:
Keywords: multipolygon Cc: openstreetmap@…

Description

Osmarender (orp.pl) overwrites tags given to a multipolygon by copying all tags data from its outer ways to the multipolygon itself. Thereby it doesn't honor already assigned tag keys. Which results in e.g. a wrong nameing of the multipolygon and a bad placement of the name label (in zoom level 17). See unpatched.png - the name of the place is actually the name of the street.

The attached patch fixes this by not copying any tag data from outer ways to an advanced multipolygon. In case of a simple multipolygon (only one outer way), it copies only that data from the outer way that isn't yet assigned to the multipolygon, without touching present tag data. See patched.png - the place is now named right and the label is placed over the multipolygon's center.

Attachments (2)

orp.pl.diff (2.1 KB) - added by Irrfahrt 9 years ago.
orp.pl (3.0 KB) - added by Irrfahrt 9 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by Irrfahrt

Cc: openstreetmap@… added; openstreetmap@… removed

Changed 9 years ago by Irrfahrt

Attachment: orp.pl.diff added

comment:2 Changed 9 years ago by Irrfahrt

Enhanced the patch to be less strict and introduced a compatibility mode for multipolygon relations following older tagging rules.

Changed 9 years ago by Irrfahrt

Attachment: orp.pl added

comment:3 Changed 9 years ago by osm@…

Resolution: fixed
Status: newclosed

Applied in r21256. I'll close this ticket for now. Please reopen if you have a patch for or/xml or if the patch for or/p creates any problems for you.

comment:4 Changed 9 years ago by petschge

(In [21278]) Update patch by Irrfahrt commited in r21256. Should finally fix #2904.

Note: See TracTickets for help on using tickets.