Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

waterway=lock chevrons have random orientation #2915

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 9 comments
Closed

waterway=lock chevrons have random orientation #2915

openstreetmap-trac opened this issue Jul 23, 2021 · 9 comments

Comments

@openstreetmap-trac
Copy link

Reporter: malcolm.herring[at]btinternet.com
[Submitted to the original trac issue database at 9.40pm, Sunday, 25th April 2010]

eg. http://b.tah.openstreetmap.org/Tiles/tile/17/64992/42018.png

@openstreetmap-trac
Copy link
Author

Author: osm[at]petschge.de
[Added to the original trac issue at 5.36pm, Thursday, 6th May 2010]

That tile looks fine and the lock should always point with the pointy and towards upstream of the waterway...

@openstreetmap-trac
Copy link
Author

Author: malcolm.herring[at]btinternet.com
[Added to the original trac issue at 6.36am, Friday, 7th May 2010]

Sorry, I seem to have pointed to a good one. Try this:

http://b.tah.openstreetmap.org/Tiles/tile/16/32575/21109.png

What I see is:

Downstream chevron is at right angles to way (points to bank).
Upstream chevron is about 45 degrees to way.

@openstreetmap-trac
Copy link
Author

Author: malcolm.herring[at]btinternet.com
[Added to the original trac issue at 4.44pm, Sunday, 9th May 2010]

OK, now this is wierd - that same tile now shows the upstream chevron with the correct orientation. (The downstream one is still at right angles). I will attach the PNG file rather than the link.

@openstreetmap-trac
Copy link
Author

Author: malcolm.herring[at]btinternet.com
[Added to the original trac issue at 7.24am, Thursday, 13th May 2010]

... and now it has reverted to the orientation I originally reported. See second attachment.

@openstreetmap-trac
Copy link
Author

Author: osm[at]petschge.de
[Added to the original trac issue at 9.08am, Thursday, 13th May 2010]

Ok, I see what you mean. I'll look into it.

http://www.openstreetmap.org/?lat=53.78238&lon=-1.05883&zoom=17&layers=0B00FTFT

@openstreetmap-trac
Copy link
Author

Author: osm[at]petschge.de
[Added to the original trac issue at 10.33am, Thursday, 13th May 2010]

Hrm. That might at heart be a duplicate of #1982.

@openstreetmap-trac
Copy link
Author

Author: malcolm.herring[at]btinternet.com
[Added to the original trac issue at 11.00am, Thursday, 13th May 2010]

That fits with the situation at the downstream gate, but not the upstream gate. The only ways attached to that node are in line with each other. Also, why does it change from render to render?

I have edited that downstream gate node so that the way which is at right anlges to the lock way does not have a node at that point. If the problem on that gate goes away, then that would be an example of #1982.

However, the upstream gate variable orientation would appear to be a separate problem.

@openstreetmap-trac
Copy link
Author

Author: malcolm.herring[at]btinternet.com
[Added to the original trac issue at 1.05pm, Thursday, 13th May 2010]

... and that did undo the right-angle orientation, but it still is not correct. (See third file attached)

@openstreetmap-trac
Copy link
Author

Author: petschge
[Added to the original trac issue at 6.51pm, Saturday, 12th June 2010]

(In [21673]) Make sure that lock chevrons only are oriented along k=waterway
v=artificial|canal|ditch|drain|river|stream. This most importantly omits
k=waterway v=riverbank. This relies on the new properties of orp
introduced in the last commits and fixes #2915

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant