Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Join ways with coincident ends #2925

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

Join ways with coincident ends #2925

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: tms13
[Submitted to the original trac issue database at 11.52am, Sunday, 2nd May 2010]

When copying features from Shape Files, ways may need to be joined, but the shapefile importer doesn't create a single node for the common point. So it's necessary to merge coincident nodes before the ways can be joined. The attached patch automates this, and I can submit it if wanted.

I've been using it for some OS OpenData import, and I'm happy with its performance.

@openstreetmap-trac
Copy link
Author

Author: Koying
[Added to the original trac issue at 2.36pm, Sunday, 2nd May 2010]

It is a nice functionality and I trust you tested it so please go ahead.

It would be great if the 2 "mergeNodes" could be, er, merged to avoid code duplication but I can handle it if you don't feel like doing it.

@openstreetmap-trac
Copy link
Author

Author: tms13
[Added to the original trac issue at 3.16pm, Sunday, 2nd May 2010]

It's intentional to have a different mergeNodes, to make the simple case more efficient. I'll check it in as is, and then look at unifying the two.

Actually, I just realised that I moved it away from the public one, but I should have just declared it up-front and kept the code together. So I'll change that before checkin.

@openstreetmap-trac
Copy link
Author

Author: tms13
[Added to the original trac issue at 3.41pm, Sunday, 2nd May 2010]

Now checked in [21084].

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant