Opened 9 years ago

Closed 9 years ago

#2925 closed enhancement (fixed)

Join ways with coincident ends

Reported by: Toby Speight Owned by: Toby Speight
Priority: major Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

When copying features from Shape Files, ways may need to be joined, but the shapefile importer doesn't create a single node for the common point. So it's necessary to merge coincident nodes before the ways can be joined. The attached patch automates this, and I can submit it if wanted.

I've been using it for some OS OpenData? import, and I'm happy with its performance.

Attachments (1)

join.patch (3.4 KB) - added by Toby Speight 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Toby Speight

Attachment: join.patch added

comment:1 Changed 9 years ago by Chris Browet

Owner: changed from cbro@… to Toby Speight

It is a nice functionality and I trust you tested it so please go ahead.

It would be great if the 2 "mergeNodes" could be, er, merged to avoid code duplication but I can handle it if you don't feel like doing it.

comment:2 Changed 9 years ago by Toby Speight

It's intentional to have a different mergeNodes, to make the simple case more efficient. I'll check it in as is, and then look at unifying the two.

Actually, I just realised that I moved it away from the public one, but I should have just declared it up-front and kept the code together. So I'll change that before checkin.

comment:3 Changed 9 years ago by Toby Speight

Resolution: fixed
Status: newclosed

Now checked in [21084].

Note: See TracTickets for help on using tickets.