Opened 9 years ago

Closed 9 years ago

#2926 closed defect (fixed)

Force Upload doesn't work on relation

Reported by: Toby Speight Owned by: cbro@…
Priority: major Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

I'm working on the shapefile importer to read polygons with holes in. I've got it working (and will submit a patch soon), but it's not as useful as I'd like because the multipolygons generated don't get shifted to the dirty layer when Feature/Force? Upload is used. I'd expect the relation and all its members to be moved to the dirty layer.

Attachments (1)

2926.patch (2.6 KB) - added by Toby Speight 9 years ago.
New patch, against svn HEAD

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by Toby Speight

I'm willing to commit this patch when it's reviewed. Thanks.

comment:2 Changed 9 years ago by Toby Speight

Forgot to mention: the patch also improves performance of commit, because of the log(N) QList<>.contains() call in the inner loop; we now use a much more efficient QSet<> for that. That's why I ripped out the innards entirely. I have to admit, I don't understand what it's doing with the Properties dock - have I maintained the right behaviour there?

comment:3 Changed 9 years ago by Chris Browet

Resolution: fixed
Status: newclosed

(In [21103]) FIX : Allow to "Force Upload" relations, too (fixes #2926)

comment:4 Changed 9 years ago by Chris Browet

Resolution: fixed
Status: closedreopened

Ooopss... Doing twice the work...

comment:5 Changed 9 years ago by Chris Browet

Indeed a QSet is better idea. I'll review your patch and pick up best of both worlds

Changed 9 years ago by Toby Speight

Attachment: 2926.patch added

New patch, against svn HEAD

comment:6 Changed 9 years ago by Chris Browet

Please go ahead and commit. My modification do not handle recursive relations while yours do.

comment:7 Changed 9 years ago by Chris Browet

Resolution: fixed
Status: reopenedclosed

Thanks

Note: See TracTickets for help on using tickets.