Opened 9 years ago

Closed 6 years ago

#2929 closed enhancement (wontfix)

Reduce allocation of temporary strings

Reported by: strk Owned by: richard@…
Priority: critical Milestone:
Component: potlatch (flash editor) Version:
Keywords: Cc:

Description

The attached patch makes creation of String objects explicit rather than implicit (any "string".method() call implicitly creates an object) so that the same object is passed around rather than a new one is created.

Reducing object allocations, especially in loops, plays nicer with Gnash. See https://savannah.gnu.org/bugs/?func=detailitem&item_id=28009 for the details.

Attachments (2)

singleTemporaryObjectPerPhoto.patch (540 bytes) - added by strk 9 years ago.
avoidTemporaryObjects.patch (552 bytes) - added by strk 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by strk

Changed 9 years ago by strk

Attachment: avoidTemporaryObjects.patch added

comment:1 Changed 9 years ago by strk

Richard, planning to commit the patch ?

comment:2 Changed 9 years ago by Richard

Priority: majorcritical

I am, yes, but haven't looked at P1 for a while yet as I've been concentrating on P2 (and haven't yet figured out the whole git stuff needed to file new versions of the P1 swf). Will try and get a minute to do so asap.

comment:3 Changed 6 years ago by iandees

Resolution: wontfix
Status: newclosed

Cleaning aging tickets.

Note: See TracTickets for help on using tickets.