Ticket #2957 (new enhancement)

Opened 4 years ago

Last modified 3 years ago

Prevent duplicate posting on diary comments

Reported by: Andy Allan Owned by: rails-dev@…
Priority: trivial Milestone:
Component: website Version:
Keywords: Cc:

Description

Loads of people post duplicate diary comments. I'm sure there will be a funky thing in rails to either prevent duplicate submissions, or we should just prevent people from posting the same text anyway

Attachments

deduplicate_diary.patch Download (4.4 KB) - added by amm 3 years ago.
Prevent duplicates in diary entries

Change History

comment:1 Changed 4 years ago by JohnSmith

fixing duplicate diary entries would also be a good idea.

comment:2 Changed 3 years ago by amm

  • Type changed from defect to enhancement

People continue to post duplicate diary entries and comments (e.g. http://www.openstreetmap.org/user/bigboss/diary ), so here is a quick patch to prevent such duplicates.

It simply looks at the last entry and compares it to the new entry. If it is identical, then it won't get added.

Changed 3 years ago by amm

Prevent duplicates in diary entries

comment:3 Changed 3 years ago by TomH

I took the radical approach of fixing the underlying problem that was causing errors that made people thing their diary entries hadn't posted.

Somehow that seems more sensible than pasting over the cracks.

comment:4 Changed 3 years ago by amm

How do you fix that occasionally the servers respond slowly, or that someone might accidentally do a double click on the "save" button?

Although there might have been specific issues this time that have caused people frequently to post their diary entry multiple times, there will always be some reasons for people to press the save button more than once, as e.g. the age of this bug report shows. So I think it is still worth "pasting over those cracks" in addition to fixing any specific issues.

comment:5 Changed 3 years ago by TomH

I understand the logic, but I'm reluctant to do anything which makes it less likely that people will report problems.

I didn't actually close the bug, so I am still considering it, but the patch looked like it would need some work and I didn't have time to go through it right now.

comment:6 Changed 3 years ago by TomH

  • Owner changed from tom@… to rails-dev@…
Note: See TracTickets for help on using tickets.