Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Remove/detach polygon 'end' node breaks polygon #2983

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

Remove/detach polygon 'end' node breaks polygon #2983

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: tms13
[Submitted to the original trac issue database at 9.19am, Friday, 21st May 2010]

Create a polygon. Remove or detach a non-end node; the polygon is still closed. Remove or detach one of the terminal nodes, and the polygon now becomes a polyline terminated at the previously penultimate nodes.

If we're treating polygons cleverly when splitting, then we should be consistent when removing nodes from them.

@openstreetmap-trac
Copy link
Author

Author: Koying
[Added to the original trac issue at 10.07am, Sunday, 23rd May 2010]

I guess keeping the polygon closed when removing an end-node is way to go, right?

If the user wants to break the polygon, he should use the proper tool...

@openstreetmap-trac
Copy link
Author

Author: tms13
[Added to the original trac issue at 10.27am, Sunday, 23rd May 2010]

That's what I think, given how we're careful to hide the mechanics of where the start/end is.

I think that the Right Thing is to detect this case and join the loose ends when the start/end node is removed from the way.

I'm willing to look into it myself now (I submitted the ticket when I was busy with other stuff, but I have the time and knowledge now). Stop me if you're already on it!

@openstreetmap-trac
Copy link
Author

Author: Koying
[Added to the original trac issue at 11.03am, Sunday, 23rd May 2010]

I'm on it;-)

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 11.22am, Sunday, 23rd May 2010]

(In [21420]) FIX : for consistency, when deleting the end-node of a polygon, don't break it (fixes #2983)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant