Ticket #3017 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Drag onto end node truncates way

Reported by: tms13 Owned by: Koying
Priority: major Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

If I drag a node (real or virtual) onto the start or end node of a way (for example, I've imported a side road, and I'm shifting the main road to meet it at the T-junction) and answer Yes to have Merkaartor merge the nodes, then the end node becomes detached from the original way, so that the two ways are not joined.

If I select the end node in question, and then select the node to merge, and use the Merge Nodes command, then I get a junction as I expect. So it's specific to dragging nodes.

If I drag a node onto a non-terminal node of the way, then I get a crossroads as I expect. So it's specific to start and end nodes.

The bug doesn't occur with ways I draw myself, so I wonder if it's something to do with the target node originating as a junction in the shapefile from which I've forced its upload? And therefore nothing to do with it being at the end?

Any ideas?

Attachments

NG37-extract.tar.gz Download (955 bytes) - added by tms13 4 years ago.

Change History

comment:1 Changed 4 years ago by Koying

  • Owner changed from cbro@… to Koying
  • Status changed from new to assigned

It looks a tad complicated to reproduce.

Would you mind enumerating a step-by-step way to reproduce?

Changed 4 years ago by tms13

comment:2 Changed 4 years ago by tms13

I've attached a shape file extract from OS OpenData? NG37; if you load that you'll see a crossroads. Download OSM data - there's a minor road that's asking to be surveyed. If you now drag a node of that minor road onto the crossroad node, and say yes to merge the nodes, you'll see parts of all the shapefile ways disappear.

Is that reproducible for you?

comment:3 Changed 4 years ago by Koying

Yes, I can reproduce it.

Funny thing is that if you save an mdc and reload it before merging, the problem does not occur...

comment:4 Changed 4 years ago by koying

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [21518]) FIX : When importing SHP, make sure the same feature is not added multiple times to the layer (fixes #3017)

comment:5 Changed 4 years ago by tms13

Ah, well fixed. I wondered what was going on...

Note: See TracTickets for help on using tickets.