Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Drag onto end node truncates way #3017

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments
Closed

Drag onto end node truncates way #3017

openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments

Comments

@openstreetmap-trac
Copy link

Reporter: tms13
[Submitted to the original trac issue database at 12.18pm, Friday, 28th May 2010]

If I drag a node (real or virtual) onto the start or end node of a way (for example, I've imported a side road, and I'm shifting the main road to meet it at the T-junction) and answer Yes to have Merkaartor merge the nodes, then the end node becomes detached from the original way, so that the two ways are not joined.

If I select the end node in question, and then select the node to merge, and use the Merge Nodes command, then I get a junction as I expect. So it's specific to dragging nodes.

If I drag a node onto a non-terminal node of the way, then I get a crossroads as I expect. So it's specific to start and end nodes.

The bug doesn't occur with ways I draw myself, so I wonder if it's something to do with the target node originating as a junction in the shapefile from which I've forced its upload? And therefore nothing to do with it being at the end?

Any ideas?

@openstreetmap-trac
Copy link
Author

Author: Koying
[Added to the original trac issue at 9.56am, Saturday, 29th May 2010]

It looks a tad complicated to reproduce.

Would you mind enumerating a step-by-step way to reproduce?

@openstreetmap-trac
Copy link
Author

Author: tms13
[Added to the original trac issue at 7.43pm, Saturday, 29th May 2010]

I've attached a shape file extract from OS OpenData NG37; if you load that you'll see a crossroads. Download OSM data - there's a minor road that's asking to be surveyed. If you now drag a node of that minor road onto the crossroad node, and say yes to merge the nodes, you'll see parts of all the shapefile ways disappear.

Is that reproducible for you?

@openstreetmap-trac
Copy link
Author

Author: Koying
[Added to the original trac issue at 2.44pm, Sunday, 30th May 2010]

Yes, I can reproduce it.

Funny thing is that if you save an mdc and reload it before merging, the problem does not occur...

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 4.00pm, Sunday, 30th May 2010]

(In [21518]) FIX : When importing SHP, make sure the same feature is not added
multiple times to the layer (fixes #3017)

@openstreetmap-trac
Copy link
Author

Author: tms13
[Added to the original trac issue at 10.30pm, Sunday, 30th May 2010]

Ah, well fixed. I wondered what was going on...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant