Ticket #3026 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Merkaartor: recent incompatibility with Qt < 4.5

Reported by: gibson Owned by: cbro@…
Priority: major Milestone:
Component: merkaartor Version:
Keywords: Cc: "Bernd, Zeimetz", <bernd@…>

Description

It may be intentional or not, but some recent changes brought an incompatibility with Qt versions smaller than 4.5.

The project file does not check for a specific version, so I assume it was by accident.

The function calls of the style:

QColorDialog::getColor(BgColor, this, tr("Select Color"), QColorDialog::ShowAlphaChannel);

were introduced with Qt 4.5, according to  http://doc.trolltech.com/4.5/qcolordialog.html#getColor

Earlier versions need the simpler alternative function with less arguments.

The attached patch fixes the issue for me with Qt 4.4.3.

Attachments

merkaartor-SVN-r21558-qt44.01.patch Download (7.9 KB) - added by gibson 4 years ago.
patch to fix compatibility with Qt < 4.5

Change History

Changed 4 years ago by gibson

patch to fix compatibility with Qt < 4.5

comment:1 Changed 4 years ago by koying

  • Status changed from new to closed
  • Resolution set to fixed

(In [21565]) FIX : compilation with 4.4.3 (closes #3026; by gibson)

comment:2 Changed 4 years ago by Koying

  • Cc "Bernd, Zeimetz", <bernd@…> added

Thanks, I'll trust you on this one.

It's been a while I don't have a Qt 4.4 available

Copy to Bernd because he asked me about Qt 4.4 compatibility at one point...

Note: See TracTickets for help on using tickets.