Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Rendering a generic shop icon #3043

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 10 comments
Closed

Rendering a generic shop icon #3043

openstreetmap-trac opened this issue Jul 23, 2021 · 10 comments

Comments

@openstreetmap-trac
Copy link

Reporter: JohnSmith
[Submitted to the original trac issue database at 8.41pm, Tuesday, 8th June 2010]

Currently only a limited subset of shops render at all, it would be nice to have a generic shop icon render if any sort of shop=* tag is present if nothing more specific is already described in the mapnik style sheet.

@openstreetmap-trac
Copy link
Author

Author: Pieren
[Added to the original trac issue at 10.57am, Wednesday, 9th June 2010]

This is something I wanted in the past. But when I see the result now on google maps, it's a real bad idea : the street names disappear behind business information ! It's not my concept of the main OSM showcase as Mapnik is currently. That can be done somewhere else.

@openstreetmap-trac
Copy link
Author

Author: JohnSmith
[Added to the original trac issue at 11.06am, Wednesday, 9th June 2010]

Replying to [comment:1 Pieren]:

This is something I wanted in the past. But when I see the result now on google maps, it's a real bad idea : the street names disappear behind business information ! It's not my concept of the main OSM showcase as Mapnik is currently. That can be done somewhere else.

This is the benefit of having data available, not just tiles which you can put icons on top of, mapnik will shift the name of the street out of the way so the icon and the name don't overlap, also a lot of shops are off the road so shouldn't interfere too much if they are placed properly, google seems to do a lot of geocoding and places icons directly on top of the road ways.

@openstreetmap-trac
Copy link
Author

Author: Waldo000000
[Added to the original trac issue at 9.16pm, Wednesday, 9th June 2010]

Two things:

  1. This is more likely to happen if you can find/propose a suitable "generic shop icon"
  2. Care should be taken in mapnik to only render these "generic" icons when they do not interfere with other (already rendered) features. i.e. Presumably, POI's that are specifically/specially rendered already are more "important" than these generic icons. That is, when a collision occurs, presumably the "generic" icon should be hidden to make way for the other feature(s).

@openstreetmap-trac
Copy link
Author

Author: JohnSmith
[Added to the original trac issue at 11.29pm, Wednesday, 9th June 2010]

Replying to [comment:3 Waldo000000]:

Two things:

  1. This is more likely to happen if you can find/propose a suitable "generic shop icon"

I posted this in part to get ideas about what people think a generic shop icon would look like, would a hand basket be good enough, or a shopping cart, or ... ?

  1. Care should be taken in mapnik to only render these "generic" icons when they do not interfere with other (already rendered) features. i.e. Presumably, POI's that are specifically/specially rendered already are more "important" than these generic icons. That is, when a collision occurs, presumably the "generic" icon should be hidden to make way for the other feature(s).

mapnik can handle if then else, so this would be a last resort if nothing else was rendered, my hope is if something renders, rather than nothing, people will enter a lot more POIs because they then show up on a map.

@openstreetmap-trac
Copy link
Author

Author: fluteflute
[Added to the original trac issue at 8.10am, Thursday, 24th June 2010]

Sorry, added that attachment to the wrong ticket!

@openstreetmap-trac
Copy link
Author

Author: info[at]cms-db.de
[Added to the original trac issue at 9.50pm, Monday, 16th August 2010]

I'd suggest using a simple circle as generic shop icon, as a shopping basket is already used for a specific shop.

And I think that in most cases, when there are many shops, it would be better to display only the icon instead of nothing if it wouldn't fit as icon plus text. So in the lower zoom levels the text should never be displayed, as it would probably hide the street underneath, and only the more important shops should be displayed. When zooming in, more and more shops should be displayed and for the important shops the names should come in. In the highest zoom mode, all shops should be visible, and (if possible) all shops should be displayed as icon plus text. An additional zoom level would be great for this, but probably it would be a problem because of limited resources.

@openstreetmap-trac
Copy link
Author

Author: richlv
[Added to the original trac issue at 5.07am, Tuesday, 12th April 2011]

any chance to get this in ?
would increase motivation to actually map shops that are not in one of the generally recognised categories, and would also allow to get real life exposure for shop tags not "approved" on the wiki

@openstreetmap-trac
Copy link
Author

Author: richlv
[Added to the original trac issue at 4.10am, Monday, 25th April 2011]

this seems to be undeservedly ignored :)

when mapping, lots of shops do not fall under the quite narrow range that is recognised by the mapnik layer. this, of course, takes out a bit of motivation.

for example, http://www.openstreetmap.org/?lat=30.38945&lon=-97.732099&zoom=18&layers=M would be more useful if it rendered a bit more shops that are already mapped.\

i believe this would also server as a (minor, but still) motivator to introduce more people to osm ("hey, your shop is on osm, maybe worth to add a map to your homepage").

@openstreetmap-trac
Copy link
Author

Author: oddityoverseer
[Added to the original trac issue at 8.19pm, Wednesday, 14th August 2013]

I just commited a change to the openstreetmap-carto project resolving this bug: gravitystorm/openstreetmap-carto#117

@openstreetmap-trac
Copy link
Author

Author: math1985
[Added to the original trac issue at 2.11pm, Monday, 31st March 2014]

Duplicate with gravitystorm/openstreetmap-carto#116

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant