Opened 13 years ago

Closed 12 years ago

#316 closed defect (fixed)

Wide rivers need to be filled

Reported by: osm@… Owned by: crschmidt
Priority: major Milestone:
Component: mapnik Version:
Keywords: Cc:

Description

The River Thames is tagged up along its route through London using the waterway=riverbank tag. This should fill in blue, but at the moment just has a blue line along each bank.

You can see it here: http://labs.metacarta.com/osm/?lat=6671895.72064&lon=-23250.48002&zoom=12&layers=B

Change History (3)

comment:1 Changed 13 years ago by crschmidt@…

Unfortunately, the OSM data doesn't make this possible, because that is not a 'closed' way. I have no way of knowing where the thames should be filled in.

(This is a case where a human can see it easily, and a computer can't see it at all.)

comment:2 in reply to:  1 Changed 13 years ago by osm@…

Replying to crschmidt@crschmidt.net:

Unfortunately, the OSM data doesn't make this possible, because that is not a 'closed' way. I have no way of knowing where the thames should be filled in.

(This is a case where a human can see it easily, and a computer can't see it at all.)

Osmarender manages to do it by simply tracing round the segments' start and end points in segment order. This jumps the gaps and effectively closes the way. The whole river is done like this where the north and south banks form way sections that can be closed and filled by the renderer -- all the segments are correctly ordered in their ways for this to happen.

Dunno whether the riverbank tag is being used elsewhere where this shouldn't happen though... I haven't seen anywhere where it breaks anything yet.

comment:3 Changed 12 years ago by Bruce Cowan

Resolution: fixed
Status: newclosed

Fixed.

Note: See TracTickets for help on using tickets.