Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Wide rivers need to be filled #316

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

Wide rivers need to be filled #316

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: osm[at]randomjunk.co.uk
[Submitted to the original trac issue database at 11.06pm, Wednesday, 29th November 2006]

The River Thames is tagged up along its route through London using the waterway=riverbank tag.
This should fill in blue, but at the moment just has a blue line along each bank.

You can see it here:
http://labs.metacarta.com/osm/?lat=6671895.72064&lon=-23250.48002&zoom=12&layers=B

@openstreetmap-trac
Copy link
Author

Author: crschmidt[at]crschmidt.net
[Added to the original trac issue at 7.00pm, Saturday, 2nd December 2006]

Unfortunately, the OSM data doesn't make this possible, because that is not a 'closed' way. I have no way of knowing where the thames should be filled in.

(This is a case where a human can see it easily, and a computer can't see it at all.)

@openstreetmap-trac
Copy link
Author

Author: osm[at]randomjunk.co.uk
[Added to the original trac issue at 12.25pm, Monday, 4th December 2006]

Replying to [comment:1 crschmidt[at]crschmidt.net]:

Unfortunately, the OSM data doesn't make this possible, because that is not a 'closed' way. I have no way of knowing where the thames should be filled in.

(This is a case where a human can see it easily, and a computer can't see it at all.)

Osmarender manages to do it by simply tracing round the segments' start and end points in segment order. This jumps the gaps and effectively closes the way. The whole river is done like this where the north and south banks form way sections that can be closed and filled by the renderer -- all the segments are correctly ordered in their ways for this to happen.

Dunno whether the riverbank tag is being used elsewhere where this shouldn't happen though... I haven't seen anywhere where it breaks anything yet.

@openstreetmap-trac
Copy link
Author

Author: bruce.cowan[at]dsl.pipex.com
[Added to the original trac issue at 9.01pm, Wednesday, 21st March 2007]

Fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant