Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Turn restriction broken by potlatch #3254

Open
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Open

Turn restriction broken by potlatch #3254

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Nakor
[Submitted to the original trac issue database at 12.33pm, Tuesday, 28th September 2010]

See changeset http://www.openstreetmap.org/browse/changeset/5676110 where way http://www.openstreetmap.org/browse/way/54223082 was broken in three pieces.

Way http://www.openstreetmap.org/browse/way/54223082 belongs to turn restriction http://www.openstreetmap.org/browse/relation/542976 which in its version 2 has three members with to role as a result of this edit.

Only the resulting way connected to the via node should have been kept in the relation.

@openstreetmap-trac
Copy link
Author

Author: hlaw
[Added to the original trac issue at 1.51pm, Wednesday, 20th June 2012]

Noting that halcyon/connection/actions/SplitWayAction.as has been changed to fix this
[http://git.openstreetmap.org/potlatch2.git/commitdiff/f724abb9992476257cc229f4dd5bc216cfa83bdb commit diff], but splitting ways under "to" or "from" roles of turn restrictions still does not work correctly -- in cases when the original way (rather then the new way) should no longer be involved a turn restriction, it is not removed from the relation. I have fixed a number of turn restrictions broken as a result in [http://www.openstreetmap.org/browse/changeset/11957862 this changeset] - see the history on the relations fixed for examples.

I suspect lines 80-87 under [http://git.openstreetmap.org/potlatch2.git/blob/HEAD:/net/systemeD/halcyon/connection/actions/SplitWayAction.as SplitWayAction.as] still do not work as intended but I am not familiar with the source to see exactly why.

@openstreetmap-trac
Copy link
Author

Author: iandees
[Added to the original trac issue at 7.54pm, Monday, 9th September 2013]

Cleaning aging tickets.

@openstreetmap-trac
Copy link
Author

Author: hlaw
[Added to the original trac issue at 1.44am, Monday, 24th February 2014]

The issue is still here, and as there seems no plan to deprecate Potlatch (and users are still using it) they would continue to break turn restrictions unintentionally without fixing this. Unlike new features on relations, I suppose not much effort is needed to fix this for someone familiar with the code, as there are already logics to deal with this as I read it, but they are just not working as intended.

@openstreetmap-trac
Copy link
Author

Author: rickmastfan67
[Added to the original trac issue at 5.34am, Monday, 24th February 2014]

This should go for all relations.

I just found that a user unknowingly that destroyed several route relations for Pennsylvania State Highways via P2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant