Opened 9 years ago

Closed 7 years ago

#3266 closed defect (fixed)

Update stylesheet for new power=generator tagging

Reported by: tom@… Owned by: mapnik-team@…
Priority: minor Milestone:
Component: mapnik Version:
Keywords: Cc:

Description

The tags combined with power=generator have recently been revised following a proposal I wrote. The tags 'power_source' and 'power_rating' have been deprecated. See the new schema here:

http://wiki.openstreetmap.org/wiki/Tag:power%3Dgenerator

The stylesheet needs to change from this:

<Rule>

<MaxScaleDenominator?>20000</MaxScaleDenominator?> <Filter>[man_made]='power_wind' or ([power]='generator' and [power_source] = 'wind')</Filter> <PointSymbolizer? file = "%SYMBOLS_DIR%/power_wind.png" type="png" width="16" height="26" />

</Rule>

To this:

<Rule>

<MaxScaleDenominator?>20000</MaxScaleDenominator?> <Filter>[man_made]='power_wind' or ([power]='generator' and [power_source] = 'wind') or ([power]='generator' and [generator:source] = 'wind')</Filter> <PointSymbolizer? file = "%SYMBOLS_DIR%/power_wind.png" type="png" width="16" height="26" />

</Rule>

Change History (10)

comment:1 Changed 9 years ago by Schusch

as far as I see it, it is done here:

http://trac.openstreetmap.org/changeset/23651

but it still doesn't work - I changed the wind turbine tagging in this area:

http://www.informationfreeway.org/?lat=52.17521032657653&lon=11.461634062973785&zoom=16&layers=0FB0F0

(no wind turbines anymore now to see in mapnik rendering)

but didn't touch it in this area:

http://www.informationfreeway.org/?lat=52.174012851447&lon=11.5535372527544&zoom=16&layers=0FB0F0

(wind turbines are still there)

It would be really nice to add the support for the new power mapping scheme (http://wiki.openstreetmap.org/wiki/Key:generator:source) in mapnik

And by the way - thanks for your good work up to now :-)

Greetings, Schusch

comment:2 Changed 9 years ago by tom@…

I've no idea when those mapnik changes will be reflected in the rendering, but you might want to leave the old tags intact whilst adding the new ones to assist people whose tools don't have the new schema yet.

For example, there's no need to delete 'power_source=wind' when adding 'generator:source=wind'.

comment:3 Changed 9 years ago by Ldp

This particular change will not be rendered anytime soon, as it was reverted right away: http://trac.openstreetmap.org/changeset/23652

The reason is that we do not have every tag available in mapnik's current database, and generator:source is one of those we do not have yet.

comment:4 Changed 9 years ago by tom@…

Thanks for the update, do you know when you will have it?

comment:5 Changed 8 years ago by Schusch

I sended Steve an email - he reverted the change, writing it is an error - perhaps he didn't see the new tagging scheme?

comment:6 Changed 8 years ago by Ldp

The reason for the revert was that we don't have generator:source in the rendering db yet.

comment:7 Changed 8 years ago by don-vip

Is there a way to see ourselves when the tag is in the rendering db ?

comment:8 Changed 8 years ago by Schusch

any chance for a change more than a year for the new tagging scheme? most of the keys now have the old and the new tags because only the old ones are rendered ...

comment:9 Changed 7 years ago by Ldp

Added in r27809

comment:10 Changed 7 years ago by Ldp

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.