Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

trac configuration: show diff view for changeset #3365

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

trac configuration: show diff view for changeset #3365

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: sebastiank
[Submitted to the original trac issue database at 12.53pm, Friday, 3rd December 2010]

When displaying a changeset, trac can show a unified diff, like this:

http://trac.openstreetmap.org/changeset/24552

however this does not work, when more than 1 file has been touched

http://trac.openstreetmap.org/changeset/24567

It would be handy, if it showed the diff for each changeset

max_diff_bytes and max_diff_files might be relevant settings.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 11.01pm, Friday, 3rd December 2010]

As best I can tell this is a bug in trac and therefore outside our control. The only limits we have configured are 100 files or 100000 bytes. Those are in place to prevent problems caused by large changesets taking a long time to render.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 11.15pm, Friday, 3rd December 2010]

Apparently max_diff_bytes doesn't work the way any sane person would expect - it doesn't limit the size of the diff but rather the size of the files being diffed.

The total size of the files in that commit was more than 100Kb hence the diff wasn't shown.

I've removed that limit for now since we have a robots file blocking spiders from browsing the changsesets now anyway.

@openstreetmap-trac
Copy link
Author

Author: sebastiank
[Added to the original trac issue at 12.07am, Saturday, 4th December 2010]

thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant