Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

PL2: "advanced" tab: possible to create tags with empty key #3366

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: sebastiank
[Submitted to the original trac issue database at 10.38pm, Friday, 3rd December 2010]

It shouldn't be possible to create a tag with either key or value is the string of length 0.

(See http://www.openstreetmap.org/browse/node/1019041185/history for an example.)

On top of that, it should always trim spaces at the start and at the end of a key or value string.

I'd suggest to render "(new tag)" and "(new value)" in italic font and not count it as a tag change unless both fields have been edited. It shouldn't be necessary to initialize the cell editor with this placeholder string because you never enter something ot that kind.

Why not rename "(new tag)" --> "(new key)"?

(Used the Potlatch 2 version that

@openstreetmap-trac
Copy link
Author

Author: sebastiank
[Added to the original trac issue at 7.42am, Saturday, 4th December 2010]

... is installed in the edit tab 0.5 b 24558)

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 7.21pm, Tuesday, 4th January 2011]

This should be fixed in r24973. The UI isn't particularly elegant if you try and blank a key (the DataGrid row sticks around until you select another entity) but unfortunately my poor brane gets confused when faced with DataGrid events and the tag architecture and wotnot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant