Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3380 closed enhancement (fixed)

Change default style to allways show an arrow pointing the direction for active lines.

Reported by: extremecarver Owned by: Richard
Priority: major Milestone:
Component: potlatch2 Version:
Keywords: Cc:

Description

Even though it is nice that oneway=yes or -1 is displayed via the style, it is not friendly at all (and therefore makes P2 for me unusable) that the direction otherwise by default is not shown (at least for the active line). In P1 the direction reverse arrow pointed the direction of every line, which was very good too (except for circles).

There are plenty of things that are direction dependant (any multipolygon, rivers, skipistes, incline, forward/backward, left/right or any key that is only applicable to one side of a street (of which plenty exist), a myriad of restrictions, ......).

One cannot expect users to change the style to show this, nor would it be practical (too much clutter), to display arrows for every way. Hence the direction reverse arrow has to indicate the direction of any line just as it did in P1, or better, if any line is selected there should be some sort of arrows to indicate which direction the line is facing (a circle is a closed line, so arrows too).

Change History (9)

comment:1 Changed 9 years ago by Richard

We aim to add Potlatch 1-like behaviour with the direction arrow. However it's a much more difficult task in ActionScript? 3/Flex than it was in ActionScript? 1, which is why we haven't done so yet (despite spending some hours on the problem).

For the record, Potlatch 1 did indeed show the direction of circles, though you had to look pretty closely!

comment:2 Changed 9 years ago by extremecarver

Okay, good to know. Why not show arrows for any active way then? (the only real confusing problem is that many people might expect the arrows to show backwards, if say oneway=-1 is tagged - but that could be solved by showing then two arrows, one for the driving direction inside the street, and one outside showing the direction of the line).

comment:3 Changed 9 years ago by Richard

Drawing arrows is very computationally expensive - especially on a really long way (we haven't implemented clipping regions for way drawing yet, so everything is recalculated on each redraw including off-screen regions). Certainly there's nothing to stop someone coming up with a style that does this but I'd be loth to include it as the default style!

comment:4 Changed 9 years ago by stevage

Since I forgot about Richard's comment until now, I made some styles as suggested and put them in [25117]. See my checkin comments.

Oh, also, if MapCSS supported simultaneous :selected and :hover, I'd be tempted to make that the time at which direction arrows show up.

comment:5 in reply to:  4 Changed 8 years ago by BennieD

Replying to stevage:

Since I forgot about Richard's comment until now, I made some styles as suggested and put them in [25117]. See my checkin comments.

Oh, also, if MapCSS supported simultaneous :selected and :hover, I'd be tempted to make that the time at which direction arrows show up.

:I can't see this - must I add a style? How? //

comment:6 Changed 8 years ago by Richard

Owner: changed from potlatch-dev@… to Richard
Status: newassigned

The change has not yet been deployed onto the live site so you can't see it yet. Changes to the code are not automatically published to openstreetmap.org; they require manual deployment.

As per discussions on the potlatch-dev mailing list, this particular change probably won't make it into the default style; though valuable to advanced mappers, it has serious drawbacks as a default style (confusing to newcomers who don't realise it doesn't mean "one way", comparatively slow to draw which is a serious issue on Linux Flash Player).

Instead, there will be a separate 'Enhanced' style for this. I will commit this in the next few days though am busy with the day job at the moment.

comment:7 Changed 8 years ago by stevage

I'll disagree politely with two of your statements then shut up:

1) "Confusing to newcomers" - IMHO anyone who has seen a oneway=yes rendering will not get them confused. The arrows are as different as I could possibly make them.

2) Linux performance - since rendering performance on Windows seems to be vastly superior, is it worth exploring a bit further how to simplify styles for Linux users without compromising the Windows experience? It seems likely to me that the majority of Potlatch users will be Windows, so if our approach is to always develop for the lowest common denominator (Linux Flash), we're limiting ourselves quite a bit. Can the client detect the environment and thus gracefully fall back to better performance styles?

Also, with the "enhanced" style, is this: a) better styles for environments with "enhanced" performance b) more informative styles for users with "enhanced" skills c) "enhanced" detail for users who want to see more?

These are different use cases.

comment:8 Changed 8 years ago by Richard

Resolution: fixed
Status: assignedclosed

Fixed in r25152-r25170.

comment:9 in reply to:  8 Changed 8 years ago by BennieD

Replying to Richard:

Fixed in r25152-r25170.

The arrows is great - Thanks

Note: See TracTickets for help on using tickets.