Opened 9 years ago

Closed 9 years ago

#3383 closed defect (fixed)

Node order seems to change when dragging

Reported by: chriscf Owned by: potlatch-dev@…
Priority: minor Milestone:
Component: potlatch2 Version:
Keywords: Cc:

Description

Trying to edit way 30996668 (though happened with adjacent objects too). Grabbed a corner, and the shading changed as if the nodes were in a different order. Sanity restored when the mouse button is released. Screenshots attached.

Attachments (2)

beforedrag.png (105.4 KB) - added by chriscf 9 years ago.
normal state before dragging the node
afterdrag.png (103.6 KB) - added by chriscf 9 years ago.
situation while dragging - the highlighted node is being dragged, but the adjacent node is where the breakage seems to happen - whichever node is dragged, it is one of the adjacent nodes where the anomaly occurs

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by chriscf

Attachment: beforedrag.png added

normal state before dragging the node

Changed 9 years ago by chriscf

Attachment: afterdrag.png added

situation while dragging - the highlighted node is being dragged, but the adjacent node is where the breakage seems to happen - whichever node is dragged, it is one of the adjacent nodes where the anomaly occurs

comment:1 Changed 9 years ago by Richard

Yep, known issue - to speed up redraw when dragging a node in a way, we've recently started just redrawing the 'segments' either side, having drawn the whole way without these segments at the start of drag. This hugely improves performance when editing long ways.

That said, it does (for obvious reasons) also lead to these artefacts when the way is a area with a fill style. We may revert to the original behaviour for areas, or alternatively draw the stroke and fill separately (which would mean that the fill isn't redrawn as you drag, but that performance is maintained).

comment:2 Changed 9 years ago by chriscf

IMO the lattermost seems like a reasonable enough trade-off for performance, and is not surprising to the user.

comment:3 Changed 9 years ago by Richard

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.