Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

On error when saving, Potlatch sometimes duplicates ways and nodes #3389

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: hyrava
[Submitted to the original trac issue database at 9.55pm, Friday, 10th December 2010]

I was adding some buildings and when saving, some error appeared. I tried to save again and this time Potlatch said all was ok. Next time I went to edit same area, I noticed lots of duplicate ways.

@openstreetmap-trac
Copy link
Author

Author: RM87
[Added to the original trac issue at 2.49pm, Monday, 13th December 2010]

For example in this changeset had one way three times in it. Another way was drawn just two times. All nodes are also duplicated.
http://www.openstreetmap.org/browse/changeset/6598880

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 12.41pm, Sunday, 27th February 2011]

Has anyone seen this since the last comment? Any more info?

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 12.47pm, Sunday, 27th February 2011]

Of course this is going to happen. If you save a way with id -1, P2 will (rightly) send a 'create' action as part of the diff upload. If the diff result is then not received, for whatever reason, P2 doesn't know that the object has been created. So on next upload, it will try again. The same would be true for P1 or indeed any client.

This is most probably an API, server or connectivity issue, not a P2 issue. Failing a really revolting hack (e.g. examining all ways/nodes with the lat, long and tags we were trying to upload, and getting their ids - which we simply won't do) then it needs to be addressed at the appropriate level.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant