Opened 9 years ago

Closed 8 years ago

#3389 closed defect (wontfix)

On error when saving, Potlatch sometimes duplicates ways and nodes

Reported by: hyrava Owned by: potlatch-dev@…
Priority: major Milestone:
Component: potlatch2 Version:
Keywords: Cc:

Description

I was adding some buildings and when saving, some error appeared. I tried to save again and this time Potlatch said all was ok. Next time I went to edit same area, I noticed lots of duplicate ways.

Change History (3)

comment:1 Changed 9 years ago by RM87

Summary: On error when saving, Potlatch sometimes duplicates ways and maybe nodesOn error when saving, Potlatch sometimes duplicates ways and nodes

For example in this changeset had one way three times in it. Another way was drawn just two times. All nodes are also duplicated. http://www.openstreetmap.org/browse/changeset/6598880

comment:2 Changed 8 years ago by stevage

Has anyone seen this since the last comment? Any more info?

comment:3 Changed 8 years ago by Richard

Resolution: wontfix
Status: newclosed

Of course this is going to happen. If you save a way with id -1, P2 will (rightly) send a 'create' action as part of the diff upload. If the diff result is then not received, for whatever reason, P2 doesn't know that the object has been created. So on next upload, it will try again. The same would be true for P1 or indeed any client.

This is most probably an API, server or connectivity issue, not a P2 issue. Failing a really revolting hack (e.g. examining all ways/nodes with the lat, long and tags we were trying to upload, and getting their ids - which we simply won't do) then it needs to be addressed at the appropriate level.

Note: See TracTickets for help on using tickets.