Opened 8 years ago

Closed 8 years ago

#3407 closed defect (fixed)

popups not staying on the home locations map display

Reported by: Harry Wood Owned by: rails-dev@…
Priority: minor Milestone:
Component: website Version:
Keywords: home openlayers Cc:

Description

The map display showing your home location and nearby people's home locations, shows popup voice bubble things when you mouseover the markers.

These should probably stay when you click on the marker, because currently it's impossible to click on the username link which is shown there.

Change History (7)

comment:1 Changed 8 years ago by Tom Hughes

Owner: changed from Tom Hughes to rails-dev@…

comment:2 Changed 8 years ago by mvexel

Fix for this committed. According to the wiki I am not supposed to send a pull request?

This could be improved in several ways, but I lack the OL skills. I would personally prefer it if the popups would only appear once the user clicks on a marker, making it disappear again on a second click (toggle on click).

comment:3 Changed 8 years ago by mvexel

Cc: mvexel added

That commit link was not good, here it is.

comment:4 Changed 8 years ago by Tom Hughes

I don't see anything on that which says you're not supposed to send a pull request?

Moving on to the substance of the patch, I haven't tried it yet, but it looks like with that patch is applied there is nothing to remove popups, so they will just wind up proliferating until they are all open?

comment:5 in reply to:  4 Changed 8 years ago by mvexel

Cc: mvexel removed

Replying to TomH:

I don't see anything on that which says you're not supposed to send a pull request?

No, but it does explain all the other steps involved in getting a fork, changing, adding, committing. So leaving out the pull request bit is an implicit 'don't do that'.

Moving on to the substance of the patch, I haven't tried it yet, but it looks like with that patch is applied there is nothing to remove popups, so they will just wind up proliferating until they are all open?

If a new popup appears, any old ones that are still open will disappear. This may be some standard OL setting, I didn't expect it to be this simple either.

comment:6 Changed 8 years ago by Tom Hughes

Well I have no idea who wrote that stuff in the wiki anyway. As far as I'm concerned pull requests are fine.

comment:7 Changed 8 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

I've merged that fix now, and it should deployed shortly.

Note: See TracTickets for help on using tickets.