popups not staying on the home locations map display #3407
Comments
|
Author: mvexel Fix for this [http://trac.openstreetmap.org/ticket/3407 committed]. According to [https://wiki.openstreetmap.org/wiki/Committing_to_the_rails_port#Sending_patches the wiki] I am not supposed to send a pull request? This could be improved in several ways, but I lack the OL skills. I would personally prefer it if the popups would only appear once the user clicks on a marker, making it disappear again on a second click (toggle on click). |
|
Author: mvexel That commit link was not good, [https://github.com/mvexel/openstreetmap-website/commit/f86eb77f17a9f82413e1455946284c033207ba2f here] it is. |
|
Author: TomH I don't see anything on that which says you're not supposed to send a pull request? Moving on to the substance of the patch, I haven't tried it yet, but it looks like with that patch is applied there is nothing to remove popups, so they will just wind up proliferating until they are all open? |
|
Author: mvexel Replying to [comment:4 TomH]:
No, but it does explain all the other steps involved in getting a fork, changing, adding, committing. So leaving out the pull request bit is an implicit 'don't do that'.
If a new popup appears, any old ones that are still open will disappear. This may be some standard OL setting, I didn't expect it to be this simple either. |
|
Author: TomH Well I have no idea who wrote that stuff in the wiki anyway. As far as I'm concerned pull requests are fine. |
|
Author: TomH I've merged that fix now, and it should deployed shortly. |
Reporter: Harry Wood
[Submitted to the original trac issue database at 12.07am, Monday, 20th December 2010]
The map display showing your home location and nearby people's home locations, shows popup voice bubble things when you mouseover the markers.
These should probably stay when you click on the marker, because currently it's impossible to click on the username link which is shown there.
The text was updated successfully, but these errors were encountered: