Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Make circular tool is non-deterministic #3419

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 1 comment
Closed

Make circular tool is non-deterministic #3419

openstreetmap-trac opened this issue Jul 23, 2021 · 1 comment
Assignees
@openstreetmap-trac
Labels
Component: potlatch2 Priority: minor Resolution: fixed Type: defect

Comments

@openstreetmap-trac
Copy link

Reporter: seav
[Submitted to the original trac issue database at 11.22pm, Sunday, 26th December 2010]

The make circular tool is a chaotic tool since it doesn't converge on a single "answer".

Steps to reproduce:

  1. Create or select a closed polygon.
  2. Click on the make circular button several times.
  3. Observe chaotic behavior.

Potlatch 1 has the correct behavior.
@openstreetmap-trac openstreetmap-trac self-assigned this Jul 23, 2021
@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 12.40am, Sunday, 13th February 2011]

I haven't seen actual non-determinism, but there is something buggy in the centroid calculation that leads to the centroid sometimes being outside the polygon. That in turn leads to an oversized circle being created. You can see this effect on this way: http://www.openstreetmap.org/browse/way/62162934

Anyway, I have committed a fix that uses a much simpler way to compute a centroid. [25277]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: potlatch2 Priority: minor Resolution: fixed Type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac