Ticket #3452 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] overflow with near-pole data and mercator

Reported by: Komяpa Owned by: mapnik-team@…
Priority: minor Milestone:
Component: mapnik Version:
Keywords: Cc:

Description

Here's a patch to (hopefully) fix "South Pole Near Africa" problem with osm2pgsql.

Demonstration of that:

What this patch does:

  1. Checks for Sphrical Mercator;
  2. Checks whether node is a lot outside tile 0/0/0. Snaps it to boundary that does not lead to overflow;
  3. Replaces proj4 calculation with direct Spherical Mercator formula, which is less strict about overflows and gave me ~5% speedup on test dataset.

Attachments

reprojection_spherical_merc_pole_fix.diff Download (1.1 KB) - added by Komяpa 3 years ago.

Change History

Changed 3 years ago by Komяpa

comment:1 Changed 3 years ago by jburgess777@…

  • Status changed from new to closed
  • Resolution set to fixed

Patch applied with some minor tweaks in r25075.

comment:2 Changed 3 years ago by chris66

  • Priority changed from major to minor
  • Status changed from closed to reopened
  • Resolution fixed deleted

Still South Pole data can be seen at Africa:

http://www.openstreetmap.org/?lat=-0.111&lon=0.154&zoom=10&layers=M

comment:3 Changed 3 years ago by Ldp

  • Status changed from reopened to closed
  • Resolution set to fixed

It is fixed, in the tools.

Now, it takes time to work that out of the data and the map. It'll be gone after the next full import, which hopefully will not take that long anymore to start.

Note: See TracTickets for help on using tickets.