Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Streams looks strange on riverbanks #3468

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 8 comments
Closed

Streams looks strange on riverbanks #3468

openstreetmap-trac opened this issue Jul 23, 2021 · 8 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Zverik
[Submitted to the original trac issue database at 6.54am, Monday, 17th January 2011]

http://www.openstreetmap.org/?lat=57.79794&lon=28.32351&zoom=16&layers=M

Look at where the stream connects to the river inside riverbank. Streams now seem to have contour which is ok on land, but should be hidden under water. Probably riverbanks should be drawn over all other waterways.

@openstreetmap-trac
Copy link
Author

Author: osm[at]heesakkers.info
[Added to the original trac issue at 12.01pm, Wednesday, 19th January 2011]

http://trac.openstreetmap.org/changeset/24983/applications/rendering/mapnik/inc/layer-water.xml.inc

@openstreetmap-trac
Copy link
Author

Author: xificurk
[Added to the original trac issue at 10.26pm, Wednesday, 23rd February 2011]

Btw, the same goes for reservoirs and other water areas.

@openstreetmap-trac
Copy link
Author

Author: kyblicek[at]kyblsoft.cz
[Added to the original trac issue at 12.28am, Wednesday, 9th March 2011]

I wrote patch to fix it - it simply move all water lines under water areas. (Is there any case in which is desired to have any line on water area?)

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 10.03am, Wednesday, 9th March 2011]

Yes, where one waterway tunnels under another (area).

I had another solution in mind, but didn't get around to it yet. I'll try to get to it this week.

@openstreetmap-trac
Copy link
Author

Author: osm[at]heesakkers.info
[Added to the original trac issue at 10.36am, Wednesday, 9th March 2011]

The best options IMO would be to have rivers render their name, so that you don't have to "abuse" the stream tag to render names on rivers. The case of the ticketstarter would then be fixed by having the stream run up to but not in to the water-mass.

[http://trac.openstreetmap.org/ticket/2514 Ticket on rendering river names]

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 12.04pm, Wednesday, 9th March 2011]

One of the reasons the stream runs into the water mass is due to possible future waterway routing, as I understood it.

@openstreetmap-trac
Copy link
Author

Author: osm[at]heesakkers.info
[Added to the original trac issue at 12.34pm, Wednesday, 9th March 2011]

Make the part in the water-mass a river, that wouldn't break routing, would it? It is a bit [http://www.openstreetmap.org/?lat=51.382847&lon=5.396838&zoom=18&layers=M hard to aim], I have to admit that.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 12.38am, Tuesday, 15th March 2011]

Fixed and deployed in r25563.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant