Opened 9 years ago

Closed 9 years ago

#3468 closed defect (fixed)

Streams looks strange on riverbanks

Reported by: Zverik Owned by: mapnik-team@…
Priority: minor Milestone:
Component: mapnik Version:
Keywords: Cc: xificurk, Aleš Janda


Look at where the stream connects to the river inside riverbank. Streams now seem to have contour which is ok on land, but should be hidden under water. Probably riverbanks should be drawn over all other waterways.

Attachments (1)

water.patch (1.7 KB) - added by Aleš Janda 9 years ago.
Patch to fix #3468

Download all attachments as: .zip

Change History (10)

comment:2 Changed 9 years ago by xificurk

Btw, the same goes for reservoirs and other water areas.

comment:3 Changed 9 years ago by xificurk

Cc: xificurk added

Changed 9 years ago by Aleš Janda

Attachment: water.patch added

Patch to fix #3468

comment:4 Changed 9 years ago by Aleš Janda

Cc: Aleš Janda added

I wrote patch to fix it - it simply move all water lines under water areas. (Is there any case in which is desired to have any line on water area?)

comment:5 Changed 9 years ago by Ldp

Yes, where one waterway tunnels under another (area).

I had another solution in mind, but didn't get around to it yet. I'll try to get to it this week.

comment:6 Changed 9 years ago by osm@…

The best options IMO would be to have rivers render their name, so that you don't have to "abuse" the stream tag to render names on rivers. The case of the ticketstarter would then be fixed by having the stream run up to but not in to the water-mass.

Ticket on rendering river names

comment:7 Changed 9 years ago by Ldp

One of the reasons the stream runs into the water mass is due to possible future waterway routing, as I understood it.

comment:8 Changed 9 years ago by osm@…

Make the part in the water-mass a river, that wouldn't break routing, would it? It is a bit hard to aim, I have to admit that.

comment:9 Changed 9 years ago by Ldp

Resolution: fixed
Status: newclosed

Fixed and deployed in r25563.

Note: See TracTickets for help on using tickets.