Opened 8 years ago

Closed 5 years ago

#3525 closed enhancement (duplicate)

unknown building types to be like building=house

Reported by: Socks Owned by: mapnik-team@…
Priority: major Milestone:
Component: mapnik Version:
Keywords: Cc: kay_D

Description

A recent update to the style sheet renders building=house with less emphasis than significant buildings. This is great, but it's tempting to tag for the renderer and put building=house when it's actually building=garage or building=shed or anything else unknown.

The low emphasis rendering (with no outline) should be used by default (for unknown building types and building=yes) while the more significant rendering should be used for specific building types.

Change History (5)

comment:1 Changed 8 years ago by achadwick

Seconded - it's so tempting to be vague and use the less-emphasized building=residential for little sheds and garages too. I.e. the sort of building you'd find in a landuse=residential.

comment:2 Changed 8 years ago by Harry Wood

In general I feel that adding a high granularity of different values into building tags should be discouraged in favour of a simple tag (building=yes) alongside other existing tags (e.g. amenity tags) which give the building a type/use information. Having any difference of rendering for different values runs contrary to this.

It also means whichever way around the logic is, the stylesheet will end up with a bunch of different values to catch. Currently it's got 'house' and 'residential' values picked out. I kind of agree that it makes more sense for the default to be lower prominence, but a problem with this idea is... what set of values are you suggesting for high prominence?

comment:3 Changed 8 years ago by Ed Avis

It might make more sense to pick out specific tags for high prominence. That reflects the way mapping usually happens: put a vague building=yes as a first pass and refine it later. At the moment building=yes is counted as high prominence which makes little sense.

I also agree with Harry W. that amenity tags are usually the way to go.

Finally, the outline around building shapes is a really useful enhancement to the map. I would suggest keeping the outline for all buildings, even houses, and finding some other way to mark them as less significant.

comment:4 Changed 8 years ago by kay_D

Cc: kay_D added

comment:5 Changed 5 years ago by math1985

Resolution: duplicate
Status: newclosed

This issue is now being discussed on Github: https://github.com/gravitystorm/openstreetmap-carto/issues/68 Therefore, I will close this issue here.

Note: See TracTickets for help on using tickets.