Opened 8 years ago

Closed 7 years ago

#3537 closed defect (fixed)

[PATCH] Filter not working with ?key=KEY syntax

Reported by: Michi Owned by: jochen@…
Priority: major Milestone:
Component: taginfo Version:
Keywords: Cc:

Description

As stated on the OSM wiki, taginfo can be called by two different URLs:

http://taginfo.openstreetmap.de/keys/KEY

http://taginfo.openstreetmap.de/keys/?key=KEY

The filter function does work on the first URL, but not on the second, because it removes the ?key=KEY parameter and replaces it with ?filter=nodes, for example.

The problem lies in line 108 of key.erb (https://github.com/joto/taginfo/blob/master/web/views/key.erb#L108):

The key parameter is overwritten with "filter=...".

I've attached a patch.

Attachments (1)

key.erb.patch (705 bytes) - added by Michi 8 years ago.
Patch

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Michi

Attachment: key.erb.patch added

Patch

comment:1 Changed 8 years ago by Jochen Topf

Resolution: fixed
Status: newclosed

comment:2 Changed 7 years ago by AlfonZ

Resolution: fixed
Status: closedreopened

I think similar fix should be applied to tag.erb as well, so filtering works for tags called by http://taginfo.openstreetmap.org/tags/?key=KEY&value=VALUE too.

comment:3 Changed 7 years ago by Jochen Topf

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.