Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

[PATCH] Filter not working with ?key=KEY syntax #3537

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

[PATCH] Filter not working with ?key=KEY syntax #3537

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Michi
[Submitted to the original trac issue database at 5.41pm, Friday, 11th February 2011]

As stated on the OSM wiki, taginfo can be called by two different URLs:

http://taginfo.openstreetmap.de/keys/KEY

http://taginfo.openstreetmap.de/keys/?key=KEY

The filter function does work on the first URL, but not on the second, because it removes the ?key=KEY parameter and replaces it with ?filter=nodes, for example.

The problem lies in line 108 of key.erb (https://github.com/joto/taginfo/blob/master/web/views/key.erb#L108):

The key parameter is overwritten with "filter=...".

I've attached a patch.

@openstreetmap-trac
Copy link
Author

Author: jochen[at]topf.org
[Added to the original trac issue at 4.48pm, Wednesday, 23rd February 2011]

fixed in
taginfo/taginfo@8adbf45

@openstreetmap-trac
Copy link
Author

Author: AlfonZ
[Added to the original trac issue at 5.03pm, Wednesday, 13th June 2012]

I think similar fix should be applied to tag.erb as well, so filtering works for tags called by [http://taginfo.openstreetmap.org/tags/?key=KEY&value=VALUE] too.

@openstreetmap-trac
Copy link
Author

Author: jochen[at]topf.org
[Added to the original trac issue at 8.45am, Sunday, 17th June 2012]

Fixed in taginfo/taginfo@8f8b7bd

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant