Tag keys/values should be restricted to 255 characters #3587
Comments
Author: Richard Please provide exact steps to reproduce:
|
Author: FK270673
|
Author: Richard Ok, so the issue appears to be that P2 is not coping with very long key or value strings. I can't actually reproduce it but that doesn't matter, as we shouldn't be allowing strings of over 255 characters anyway - they'll cause an API error on upload. Summary changed; priority demoted from 'blocker' as P2 does actually show a warning (albeit a fairly ugly long one!) about tag mismatches when merging ways, and you should heed it. :) |
Author: FK270673 Today, it crashed again while editing the (TIGER) tabs of an existing power line (11837892) with Potlatch2. I tried to remove the tiger:tlid=51137899:51137901:51137903:51137905 manually when Potlatch2 crashed. There must be an error with loading/reloading/editing properties while Potlatch2 is being busy - far before the saving error appears. It would be fine if these funny numbers would disappear from the database rather than causing my editor to crash. |
Author: Richard Unfortunately your previous comment wasn't exact enough for me to be able to reproduce it, and if we can't reproduce it we can't fix it. If, as requested originally, you could provide an exact'' series of actions, we can look at it as a matter of urgency. But "about 10 pieces of power line" - what are you doing with these power lines? How, ''exactly, are you doing it? Please don't reverse the developers' classification of priorities; thanks. By definition if only one person has encountered the problem then it isn't something we would consider a blocker. |
Author: FK270673 Unfortunately, these critical errors seem to be a result of multiple conditions.
I suppose there must be a conflict between listeners, maybe the tab listener and some other reloading listener. |
Author: FK270673 This time, Potlatch2 crashed in a reproducable way when I tried to join four highways in the United States with different TIGER IDs. Then, I tried to edit their combined ID manually with the Advanced Tab which caused the crash. |
Author: Richard Both the "tag panel freezing" and the ">255 characters" issues should now have been fixed. I'd be interested to know whether this solves your problem. |
Author: Richard No further reports on this so I'm assuming it's been fixed: please reopen if not. |
Reporter: FK270673
[Submitted to the original trac issue database at 1.18pm, Tuesday, 15th March 2011]
Potlatch2 crashed three times in 24 hours when I tried to edit a textfield in the advanced properties tab. The advanced tab does NOT always reload completely when clicking the ADVANCED button, but if the advanced tab appears with all properties, it is sometimes hard to remove some unnecessary properties like TIGER ID. It happens when I tried to merge two ways with very long TIGER ID tags and to edit/remove the long TIGER ID tags. Is there any restriction for the length of any textfield that will be exceeded by a simple TIGER ID or by special characters within the TIGER ID?
Starting the Windows Task manager with Strg+Alt+Del makes the Flash player crashing and nothing than a white screen appears on the browser. I have rated it as blocker because losing some kilometers of personal effort simply sucks. Not touching TIGER IDs until saving is a workaround that enabled to get my data into the database, but it is no perfect solution, of course.
The text was updated successfully, but these errors were encountered: