Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

When saving a changeset with no description in Potlatch 2, "(none)" should show up for comment on the main site #3609

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments

Comments

@openstreetmap-trac
Copy link

Reporter: rickmastfan67
[Submitted to the original trac issue database at 9.53pm, Friday, 25th March 2011]

I've been noticing this a lot recently that any changeset made with Potlatch 2 with no comment saved shows up as a completely blank line. When this was done with Potlatch 1.4, it would at least save a comment of "(none)".

The reason I consider this a problem is because when you have a buddy use Potlatch 2 and not leave a comment, the "Latest edit" will not give you a link to go view it. It will look like this: [ Latest edit (about 1 hour ago): "" ]. Thus, forcing you to go to their profile, then edits, and then click on the changeset # to view it.

Here is a link to a user that uses both Potlatch 1.4 and 2 to show the blank and "(none)" changesets difference problems:
http://www.openstreetmap.org/user/mdroads/edits
The blank ones are Potlatch 2, the "(none}" ones are from 1.4.

So, can this be possibly fixed? I would appreciate it.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 10.39pm, Friday, 25th March 2011]

The problem is that PL2 is submitting a comment tag for the changeset with an empty string as the value.

I'll make the website handle that better, but we should fix PL2 to stop it doing that...

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 1.37pm, Sunday, 28th August 2011]

This is all fixed. Potlatch no longer sets the empty tag, and the site copes with the empty tags for old changesets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant