Opened 8 years ago

Closed 8 years ago

#3708 closed defect (fixed)

Deleted nodes now look like not deleted ones

Reported by: malenki Owned by: Tom Hughes
Priority: minor Milestone:
Component: website Version:
Keywords: Cc: emj

Description

After the last changes to the website deleted nodes now look identical to existing ones. Only the symbol of the node is not shown on the map but that could be mapnik just not rendering. All tags of the node are shown, a "deleted" like before is not visible.

I'd suggest either to strike through all tags of the deleted node and re-add the "deleted" or just turn back to the old behaviour which still shows up with ways. The behaviour atm is confusing.

Change History (6)

comment:1 Changed 8 years ago by rickmastfan67

Priority: majorcritical
Summary: Deleted nodes look like not deleted onesDeleted nodes now look like not deleted ones

I agree with you. I just discovered this today myself. Really, really annoying (hence me upgrading this to critical).

Here's an example of a deleted node: http://www.openstreetmap.org/browse/node/203267119

You can't tell it's deleted at all and would think that it's still there, just not attached to any way and has no tags.

So, can this please get fixed ASAP? Otherwise, I could start seeing more error reports about this when people discover it.

comment:2 Changed 8 years ago by Tom Hughes

Priority: criticalminor

Just because you find it annoying does not make it critical! Critical is things like "the web site is down for everybody" not "a minor feature is not as good as it could be".

For the record I've been away for a few days - this was raised while I was away and now that I'm back I will look at it as soon as I can - shouting and screaming will not make anything happen any faster.

comment:3 Changed 8 years ago by emj

Cc: emj added

I found the commits that removed the "node deleted" message we got confused by this as well.

Frederik added map for deleted nodes (by showing previous version): http://git.openstreetmap.org/rails.git/commitdiff/935c238626af44723ecb51531fe3a552831edd70?hp=0169453855de4fe308b7f27fae92021ce918d4fd

TomH removed the deleted message: http://git.openstreetmap.org/rails.git/commitdiff/aa8fef0f94e531949346ec07bc57382b18c4adde

comment:4 Changed 8 years ago by Tom Hughes

Yes I did, because it was completely inconsistent to do that for nodes and not for other objects. Also it was using a translation resource that was from a different view.

I am still considering the best way to represent deletes, and when I have decided I will do that, but I will do it for all object types, not just nodes.

comment:5 Changed 8 years ago by rickmastfan67

TomH, I'm sorry you thought I was shouting and screaming. That wasn't my intention. However, "ASAP" is normally in all caps. Could have I worded it better? Yes, I'll admit to that.

comment:6 Changed 8 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

Fixed - deletes now say "Deleted at/by" instead of "Edited at/by".

Note: See TracTickets for help on using tickets.