Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Deleted nodes now look like not deleted ones #3708

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments
Closed

Deleted nodes now look like not deleted ones #3708

openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments

Comments

@openstreetmap-trac
Copy link

Reporter: malenki
[Submitted to the original trac issue database at 8.22pm, Friday, 22nd April 2011]

After the last changes to the website deleted nodes now look identical to existing ones. Only the symbol of the node is not shown on the map but that could be mapnik just not rendering.
All tags of the node are shown, a "deleted" like before is not visible.

I'd suggest either to strike through all tags of the deleted node and re-add the "deleted" or just turn back to the old behaviour which still shows up with ways.
The behaviour atm is confusing.

@openstreetmap-trac
Copy link
Author

Author: rickmastfan67
[Added to the original trac issue at 10.43am, Monday, 25th April 2011]

I agree with you. I just discovered this today myself. Really, really annoying (hence me upgrading this to critical).

Here's an example of a deleted node: http://www.openstreetmap.org/browse/node/203267119

You can't tell it's deleted at all and would think that it's still there, just not attached to any way and has no tags.

So, can this please get fixed ASAP? Otherwise, I could start seeing more error reports about this when people discover it.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 1.10pm, Monday, 25th April 2011]

Just because you find it annoying does not make it critical! Critical is things like "the web site is down for everybody" not "a minor feature is not as good as it could be".

For the record I've been away for a few days - this was raised while I was away and now that I'm back I will look at it as soon as I can - shouting and screaming will not make anything happen any faster.

@openstreetmap-trac
Copy link
Author

Author: emj
[Added to the original trac issue at 11.22am, Thursday, 28th April 2011]

I found the commits that removed the "node deleted" message we got confused by this as well.

Frederik added map for deleted nodes (by showing previous version):
http://git.openstreetmap.org/rails.git/commitdiff/935c238626af44723ecb51531fe3a552831edd70?hp=0169453855de4fe308b7f27fae92021ce918d4fd

TomH removed the deleted message:
http://git.openstreetmap.org/rails.git/commitdiff/aa8fef0f94e531949346ec07bc57382b18c4adde

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 11.24am, Thursday, 28th April 2011]

Yes I did, because it was completely inconsistent to do that for nodes and not for other objects. Also it was using a translation resource that was from a different view.

I am still considering the best way to represent deletes, and when I have decided I will do that, but I will do it for all object types, not just nodes.

@openstreetmap-trac
Copy link
Author

Author: rickmastfan67
[Added to the original trac issue at 10.18am, Friday, 29th April 2011]

TomH, I'm sorry you thought I was shouting and screaming. That wasn't my intention. However, "ASAP" is normally in all caps. Could have I worded it better? Yes, I'll admit to that.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 7.59pm, Thursday, 5th May 2011]

Fixed - deletes now say "Deleted at/by" instead of "Edited at/by".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant