Opened 8 years ago

Closed 8 years ago

#3774 closed defect (fixed)

Sidebar unclickable (CSS problem)

Reported by: mammique@… Owned by: Tom Hughes
Priority: minor Milestone:
Component: website Version:
Keywords: Cc:

Description

When requesting a location name with a GET request, the sidebar appears to be bellow the map, so it doesn't receive clicks events to select the proper link in the proposed list.

E.g: http://www.openstreetmap.org/?query=toulouse&minlon=&minlat=&maxlon=&maxlat=

I could workaround this by adding the "z-index: 1;" property to the #sidebar CSS selector locally, I guess this fix could be integrated in the CSS stylesheet.

Change History (8)

comment:1 Changed 8 years ago by mammique@…

Component: potlatch2website
Owner: changed from potlatch-dev@… to Tom Hughes

comment:2 Changed 8 years ago by Tom Hughes

Priority: majorminor

comment:3 Changed 8 years ago by Tom Hughes

The real problem here is nothing to do with the query or CSS or anything - it's the bogus minlat etc arguments which don't have any values and hence are causing javascript errors and meaning that not all the code runs.

comment:4 Changed 8 years ago by Tom Hughes

Resolution: invalid
Status: newclosed

Closing as user error - with valid arguments in the URL there is no problem.

comment:5 Changed 8 years ago by mammique@…

I see. The thing is that I generated this query using the popular Firefox shortcut: right-click->"add keyword" on the search field, even if the mistake comes from the browser/user, it would be convenient for many user if osm could handle the omission of these variables.

Thx,

Camille.

comment:6 Changed 8 years ago by Tom Hughes

Resolution: invalid
Status: closedreopened

I never even knew Firefox could do that... It is trying to be far too clever really, assuming it can parse the form and know how to handle it.

That form does have those parameters as hidden arguments, but they are filled in by javascript before the form is submitted which Firefox has no way of knowing.

I'll see if I can make it work a bit better...

comment:7 Changed 8 years ago by mammique@…

Ha, I understand. I fixed my personal shortcut by removing the supernumerary variables. It works like this, so, to make it work for any user, these variable should be injected only on the ajax query. As the form doesn't seem to be designed to be submitted in a traditional manner (only with ajax), putting the fields outside the form (e.g. just bellow </form>) might be enough (they will be injected by the script ("minlon").value = extent.left; […]) anyway.

Tell me if this helps, I'm not familiar with osm code but I can take a deeper look if this doesn't work.

Camille.

comment:8 Changed 8 years ago by Tom Hughes

Resolution: fixed
Status: reopenedclosed

They won't get submitted if they're outside the form though, so that didn't work.

In the end I had to make it add he fields just before the submit and then remove then afterwards and that seems to work. It should be live shortly.

Note: See TracTickets for help on using tickets.