Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Sidebar unclickable (CSS problem) #3774

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments
Closed

Sidebar unclickable (CSS problem) #3774

openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments

Comments

@openstreetmap-trac
Copy link

Reporter: mammique[at]garbure.org
[Submitted to the original trac issue database at 1.26am, Thursday, 19th May 2011]

When requesting a location name with a GET request, the sidebar appears to be bellow the map, so it doesn't receive clicks events to select the proper link in the proposed list.

E.g: http://www.openstreetmap.org/?query=toulouse&minlon=&minlat=&maxlon=&maxlat=

I could workaround this by adding the "z-index: 1;" property to the #sidebar CSS selector locally, I guess this fix could be integrated in the CSS stylesheet.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 9.57am, Saturday, 21st May 2011]

The real problem here is nothing to do with the query or CSS or anything - it's the bogus minlat etc arguments which don't have any values and hence are causing javascript errors and meaning that not all the code runs.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 9.58am, Saturday, 21st May 2011]

Closing as user error - with valid arguments in the URL there is no problem.

@openstreetmap-trac
Copy link
Author

Author: mammique[at]garbure.org
[Added to the original trac issue at 5.10pm, Saturday, 21st May 2011]

I see. The thing is that I generated this query using the popular Firefox shortcut: right-click->"add keyword" on the search field, even if the mistake comes from the browser/user, it would be convenient for many user if osm could handle the omission of these variables.

Thx,

Camille.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 5.22pm, Saturday, 21st May 2011]

I never even knew Firefox could do that... It is trying to be far too clever really, assuming it can parse the form and know how to handle it.

That form does have those parameters as hidden arguments, but they are filled in by javascript before the form is submitted which Firefox has no way of knowing.

I'll see if I can make it work a bit better...

@openstreetmap-trac
Copy link
Author

Author: mammique[at]garbure.org
[Added to the original trac issue at 5.44pm, Saturday, 21st May 2011]

Ha, I understand. I fixed my personal shortcut by removing the supernumerary variables. It works like this, so, to make it work for any user, these variable should be injected only on the ajax query. As the form doesn't seem to be designed to be submitted in a traditional manner (only with ajax), putting the fields outside the form (e.g. just bellow ) might be enough (they will be injected by the script ("minlon").value = extent.left; []) anyway.

Tell me if this helps, I'm not familiar with osm code but I can take a deeper look if this doesn't work.

Camille.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 10.12am, Sunday, 22nd May 2011]

They won't get submitted if they're outside the form though, so that didn't work.

In the end I had to make it add he fields just before the submit and then remove then afterwards and that seems to work. It should be live shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant