Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

create-node timeouts and retries can create multiple identical nodes #381

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: writetodan[at]yahoo.com
[Submitted to the original trac issue database at 12.12am, Thursday, 22nd February 2007]

it appears as if when a node-creation call to the API times out and is aborted (e.g. through exceeding socket.timeout setting in HttpClient in applet's Adapter), one or automatic more retries to the API can result in multiple identical nodes being created.

unsure if/what should be done on API-side. (ticket also created against applet)

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 11.36am, Sunday, 19th August 2007]

The basic problem is that the client times out and gives up, but the server waits a bit longer and does get around to handling the pending request. Not sure there is much we can do about this.

@openstreetmap-trac
Copy link
Author

Author: karl.guggisberg[at]guggis.ch
[Added to the original trac issue at 10.24pm, Saturday, 2nd August 2008]

See
http://hc.apache.org/httpclient-3.x/exception-handling.html#HTTP_transport_safety
for idempotent http requests.

Clients could add a unique request ID to every request (i.e. a GUID?), server makes sure that every request is processed at most once. Additional requests with the same request ID would be ignored by the server. A warning could be replied to the client for duplicated requests.

@openstreetmap-trac
Copy link
Author

Author: iandees
[Added to the original trac issue at 6.31pm, Monday, 9th September 2013]

Cleaning old tickets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant