Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

OpenID failure results in some 500 errors #3822

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments
Closed

OpenID failure results in some 500 errors #3822

openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments

Comments

@openstreetmap-trac
Copy link

Reporter: emj
[Submitted to the original trac issue database at 12.58pm, Tuesday, 14th June 2011]

Bug 1

Steps:

  1. don't set an "openid URL" to login.
  2. press the "openid" logo
  3. enter your openid http://tiq.com/~erik
  4. press login.

Results:
A page with
"
Application error

The OpenStreetMap server encountered an unexpected condition that prevented it from fulfilling the request (HTTP 500)[....]"

Bug 2:

  1. Make all the steps above, then after 3.
  2. press back
  3. try to login with your password.

Results:
Will get you an 500 error as well, the openid option get stuck in someway.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 2.41pm, Tuesday, 14th June 2011]

I think it must be more complicated than that because I know people have been managing to login using custom openid URLs...

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 2.43pm, Tuesday, 14th June 2011]

When I tried it (with your URL) I got redirected off to http://tiq.com/~erik/openid/?openid.mode=authorize which just displayed a "You may not access this mode directly." message.

@openstreetmap-trac
Copy link
Author

Author: emj
[Added to the original trac issue at 3.59pm, Tuesday, 14th June 2011]

Sorry for the inconvenience.. I see that it is fixed here you have the urls:

Username:a
password:a

Results in bug
http://tiq.com/~erik/osm-openid-bug/

Works: empty strings in the "simple Registration Extension" part.
http://tiq.com/~erik/osm-openid-bug/2/

Works: fake email address in
http://tiq.com/~erik/osm-openid-bug/1/

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 4.10pm, Tuesday, 14th June 2011]

Err sorry, but have I missed something? Are you saying there is a valid OpenID response that causes us to 500? If there is then I'd like to know about it....

@openstreetmap-trac
Copy link
Author

Author: emj
[Added to the original trac issue at 5.24pm, Tuesday, 14th June 2011]

Hmm ok so this URL still doesn't work:
http://tiq.com/~erik/osm-openid-bug/

The only difference is that it hasn't got "Simple Registration Extension" enabled, so there are no values for "nickname" not "email" being sent.

@openstreetmap-trac
Copy link
Author

Author: amm
[Added to the original trac issue at 10.42pm, Tuesday, 14th June 2011]

Adding a

sreg = {} unless sreg
ax = {} unless ax

on line 547 of the user_controller.rb seems to fix this issue.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 11.38pm, Tuesday, 14th June 2011]

This should be fixed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant