Opened 8 years ago

Closed 8 years ago

#3875 closed defect (fixed)

broken rtl rails layout

Reported by: aude Owned by: Tom Hughes
Priority: critical Milestone:
Component: website Version:
Keywords: rtl, rails Cc:

Description

The OSM rails port (osm website) has very broken css for RTL languages. (see attached + patch)

Attachments (1)

0001-rtl-css-fixes.patch (2.1 KB) - added by aude 8 years ago.
rtl css patch

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by aude

Attachment: 0001-rtl-css-fixes.patch added

rtl css patch

comment:1 Changed 8 years ago by aude

The above fixes address the most critical css layout bugs, though I or someone should still go through other parts of the site (e.g. diary, user contributions...) and see what other fixes are needed.

In the longer run, there likely are better approaches than this patch, such as a separate _-rtl.css file and maybe using sass (e.g. http://amitkazmirsky.com/2011/05/29/dry-your-rtl-and-ltr-css-files-in-rails-with-sass/) or something to handle flipping layout elements. I'm willing to help work on this.

PS - here's the screenshot: http://filbertkm.com/Osmrails-rtl.png

comment:2 Changed 8 years ago by aude

Component: adminwebsite

comment:3 Changed 8 years ago by Tom Hughes

SASS doesn't appear until rails 3.1 IIRC and we're still on 2 so that is probably out for now but I'll have a look at the CSS changes you propose later.

comment:4 Changed 8 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

I applied your patch, reworked it to move the LTR/RTL stuff into separate files as you suggested and then fixed up a ton of other broken things. It should all be live shortly.

Note: See TracTickets for help on using tickets.