Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

broken rtl rails layout #3875

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

broken rtl rails layout #3875

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: aude
[Submitted to the original trac issue database at 4.43pm, Thursday, 30th June 2011]

The OSM rails port (osm website) has very broken css for RTL languages. (see attached + patch)

@openstreetmap-trac
Copy link
Author

Author: aude
[Added to the original trac issue at 3.58am, Friday, 1st July 2011]

The above fixes address the most critical css layout bugs, though I or someone should still go through other parts of the site (e.g. diary, user contributions...) and see what other fixes are needed.

In the longer run, there likely are better approaches than this patch, such as a separate ___-rtl.css file and maybe using sass (e.g. http://amitkazmirsky.com/2011/05/29/dry-your-rtl-and-ltr-css-files-in-rails-with-sass/) or something to handle flipping layout elements. I'm willing to help work on this.

PS - here's the screenshot: http://filbertkm.com/Osmrails-rtl.png

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 7.54am, Friday, 1st July 2011]

SASS doesn't appear until rails 3.1 IIRC and we're still on 2 so that is probably out for now but I'll have a look at the CSS changes you propose later.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 4.54pm, Saturday, 2nd July 2011]

I applied your patch, reworked it to move the LTR/RTL stuff into separate files as you suggested and then fixed up a ton of other broken things. It should all be live shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant