Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Potlatch crash when editing/adding tags #3893

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Potlatch crash when editing/adding tags #3893

openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments

Comments

@openstreetmap-trac
Copy link

Reporter: banoffee
[Submitted to the original trac issue database at 8.15pm, Wednesday, 6th July 2011]

I've been caught out by this several times - usually when I've got a bunch of unsaved changes :(

I've managed to get a reliable (for me) set of steps to reproduce, even if it's not a minimal test case:

  1. Load potlatch.
  2. Draw a new closed way.
  3. From the presets menu, select "Transport" section, and "Car Parking".
  4. Click 'Advanced' at bottom. Then 'Add' for a key
  5. Type 'access', 'perm', select "permissive" from auto-complete menu.
  6. Press 'Add' again, type 'name',
    (at this point, there is a key called 'name' with no value)
  7. Click where it says 'name', (e.g. to try and change to a different key such as 'operator')

Expected result: focus changes to key name, allowing this to be changed.

Actual result: Potlatch crashes, losing any work done since last save.

(undoubtedly there are other triggers, as I've stumbled into similar potlatch crashes several times, but the above steps did it every time for me from a fresh start)

@openstreetmap-trac
Copy link
Author

Author: jetthe
[Added to the original trac issue at 6.27am, Thursday, 7th July 2011]

The crash is avoided by applying this patch: jetthe/potlatch2@f3e46cc

It doesn't solve the various focus issues in the simple and advanced tabs but at least it keeps P2 from going into an infinite loop when a key with no value is selected.

@openstreetmap-trac
Copy link
Author

Author: jetthe
[Added to the original trac issue at 8.40am, Tuesday, 12th July 2011]

Fixed in openstreetmap/potlatch2@e0f8193

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant