Opened 8 years ago

Closed 5 years ago

#3906 closed enhancement (duplicate)

Proposed rendering w/icon for shop=greengrocer, shop=farm

Reported by: bryce2@… Owned by: mapnik-team@…
Priority: minor Milestone:
Component: mapnik Version:
Keywords: icon, add Cc: bryce2@…

Description

Mapping farm stands is a nice road trip activity, as it ads some interest to otherwise sparse areas of the map. Could we get an icon added in mapnik?

For example: http://www.openstreetmap.org/browse/node/1338775668

The tags are described at: http://wiki.openstreetmap.org/wiki/Key:shop . The distinction between a farm stand and greengrocer is usually clear. If it is in the middle of nowhere it is a farm stand.

Attached is a proposed rendering, which matches that already used by potlatch2.

Index: inc/layer-amenity-points.xml.inc
===================================================================
--- inc/layer-amenity-points.xml.inc	(revision 26052)
+++ inc/layer-amenity-points.xml.inc	(working copy)
@@ -352,6 +352,16 @@
     </Rule>
     <Rule>
       &maxscale_zoom17;
+      <Filter>[shop]='farm'</Filter>
+      <PointSymbolizer file="&symbols;/shop_symbol_apple.p.16.png" />
+    </Rule>
+    <Rule>
+      &maxscale_zoom17;
+      <Filter>[shop]='greengrocer'</Filter>
+      <PointSymbolizer file="&symbols;/shop_symbol_apple.p.16.png" />
+    </Rule>
+    <Rule>
+      &maxscale_zoom17;
       <Filter>[leisure]='playground'</Filter>
       <PointSymbolizer file="&symbols;/playground.p.20.png" />
     </Rule>

Attachments (1)

shop_symbol_apple.p.16.png (664 bytes) - added by bryce2@… 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by Tom Hughes

Component: adminmapnik
Owner: changed from Tom Hughes to mapnik-team@…

I'm sure you might be able to, if you raised your bug against the mapnik component...

Changed 8 years ago by bryce2@…

Attachment: shop_symbol_apple.p.16.png added

comment:2 Changed 8 years ago by bryce2@…

Cc: bryce2@… added
Type: defectenhancement

comment:3 Changed 8 years ago by bryce2@…

You may want "&maxscale_zoom15;" for shop=farm, else you'll never see the icon in most rural areas.

comment:4 Changed 7 years ago by Stemby

Keywords: icon add added

comment:5 Changed 6 years ago by bryce2@…

JOSM and pre-release iD now support shop=farm. Could this be added to OSM's rendering?

comment:6 Changed 5 years ago by math1985

Resolution: duplicate
Status: newclosed

This issue is now being discussed on Github: https://github.com/gravitystorm/openstreetmap-carto/issues/452

Therefore, I will close the issue here.

Note: See TracTickets for help on using tickets.