Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Proposed rendering w/icon for shop=greengrocer, shop=farm #3906

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

Proposed rendering w/icon for shop=greengrocer, shop=farm #3906

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: bryce2[at]obviously.com
[Submitted to the original trac issue database at 6.54pm, Wednesday, 13th July 2011]

Mapping farm stands is a nice road trip activity, as it ads some interest to otherwise sparse areas of the map. Could we get an icon added in mapnik?

For example:
http://www.openstreetmap.org/browse/node/1338775668

The tags are described at:
http://wiki.openstreetmap.org/wiki/Key:shop .
The distinction between a farm stand and greengrocer is usually clear. If it is in the middle of nowhere it is a farm stand.

Attached is a proposed rendering, which matches that already used by potlatch2.

Index: inc/layer-amenity-points.xml.inc
===================================================================
--- inc/layer-amenity-points.xml.inc	(revision 26052)
+++ inc/layer-amenity-points.xml.inc	(working copy)
@@ -352,6 +352,16 @
     </Rule>
     <Rule>
       &maxscale_zoom17;
+      <Filter>[shop]='farm'</Filter>
+      <PointSymbolizer file="&symbols;/shop_symbol_apple.p.16.png" />
+    </Rule>
+    <Rule>
+      &maxscale_zoom17;
+      <Filter>[shop]='greengrocer'</Filter>
+      <PointSymbolizer file="&symbols;/shop_symbol_apple.p.16.png" />
+    </Rule>
+    <Rule>
+      &maxscale_zoom17;
       <Filter>[leisure]='playground'</Filter>
       <PointSymbolizer file="&symbols;/playground.p.20.png" />
     </Rule>
@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 6.51am, Thursday, 14th July 2011]

I'm sure you might be able to, if you raised your bug against the mapnik component...

@openstreetmap-trac
Copy link
Author

Author: bryce2[at]obviously.com
[Added to the original trac issue at 6.57am, Thursday, 14th July 2011]

You may want "&maxscale_zoom15;" for shop=farm, else you'll never see the icon in most rural areas.

@openstreetmap-trac
Copy link
Author

Author: bryce2[at]obviously.com
[Added to the original trac issue at 5.24am, Tuesday, 23rd July 2013]

JOSM and pre-release iD now support shop=farm. Could this be added to OSM's rendering?

@openstreetmap-trac
Copy link
Author

Author: math1985
[Added to the original trac issue at 2.19pm, Monday, 31st March 2014]

This issue is now being discussed on Github: gravitystorm/openstreetmap-carto#452

Therefore, I will close the issue here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant