Opened 8 years ago

Closed 7 years ago

#4045 closed defect (fixed)

Problems with P2 after multiselecting ways

Reported by: EdLoach Owned by: potlatch-dev@…
Priority: trivial Milestone:
Component: potlatch2 Version:
Keywords: Cc:

Description

I had mapped a golf course from clubhouse back to start using a way for each hole (18 to 1), adding a note=<n> tag on each way as I went. I then checked the wiki and found golf=hole (for ways) ref=<n> proposal so thought I'd switch the tagging to that, reversing the ways so they ran tee to hole as per wiki proposal. I did the first 9 manually, then multi-selected the remainder and firstly added golf=hole, then on the off-chance it would work clicked the arrow to try and reverse direction (which didn't visibly do anything, though some ways might have been reversed afterwards - not sure. don't think all are). However after that if I changed note=n to ref=n all the other multi-selected ways already have ref=n (11 in this case) as well as note=m (for their value of m). In my case it was ways -33 and -37 which made me spot the problem, so I don't know whether it is only an issue with unsaved ways. If I'd used ref initially I probably wouldn't have noticed. I'm rating this as trivial as I don't map many golf courses, and this tag isn't rendered as far as I know (though I did like the green highlighting that P2 added).

Change History (5)

comment:1 Changed 8 years ago by EdLoach

This morning I thought I'd try and create steps to reproduce. I created two ways with tags note=1 and note=2, multi-selected them and added the tag golf=hole and changed note to ref. Now both are tagged golf=hole ref=<different>. If I then change <different> to 11 on one of the ways it shows as also changed on the other (which wasn't selected when I made the change).

comment:2 Changed 7 years ago by stevage

I had trouble understanding this at first, but can reproduce it, so for the benefit of others:

  1. Create ways tagged "note=1" and "note=2"
  2. Multi-select both (ie, ctrl+click) [you'll see note=<different>]
  3. Change "note" to "ref"
  4. When you press enter after "note", the focus shifts to the tag value, which contains the text "<different>"
  5. Clicking away to deselect seems to cause the actual value "<different>" to be stored on each way
  6. Select one way, and type a value instead of <different>, say "11"
  7. The other way, even though it's not selected, also receives this new value.

comment:3 Changed 7 years ago by stevage

Fix trac formatting:

  1. Create ways tagged "note=1" and "note=2"
  2. Multi-select both (ie, ctrl+click) [you'll see note=<different>]
  3. Change "note" to "ref"
  4. When you press enter after "note", the focus shifts to the tag value, which contains the text "<different>"
  5. Clicking away to deselect seems to cause the actual value "<different>" to be stored on each way
  6. Select one way, and type a value instead of <different>, say "11"
  7. The other way, even though it's not selected, also receives this new value.

comment:4 Changed 7 years ago by Richard

I'm halfway through solving this but it's not trivial! Hopefully have a patch before too long.

comment:5 Changed 7 years ago by Richard

Resolution: fixed
Status: newclosed

Fixed in https://github.com/systemed/potlatch2/commit/eaca14e22024f1509a8f932a509f2a7cfc81789e . At least I hope so. Thanks for the clear steps-to-reproduce which helped enormously in nailing this down.

Note: See TracTickets for help on using tickets.