Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Problems with P2 after multiselecting ways #4045

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments
Closed

Problems with P2 after multiselecting ways #4045

openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments
Assignees
@openstreetmap-trac
Labels
Component: potlatch2 Priority: trivial Resolution: fixed Type: defect

Comments

@openstreetmap-trac
Copy link

Reporter: EdLoach
[Submitted to the original trac issue database at 2.15pm, Tuesday, 11th October 2011]

I had mapped a golf course from clubhouse back to start using a way for each hole (18 to 1), adding a note= tag on each way as I went. I then checked the wiki and found golf=hole (for ways) ref= proposal so thought I'd switch the tagging to that, reversing the ways so they ran tee to hole as per wiki proposal. I did the first 9 manually, then multi-selected the remainder and firstly added golf=hole, then on the off-chance it would work clicked the arrow to try and reverse direction (which didn't visibly do anything, though some ways might have been reversed afterwards - not sure. don't think all are). However after that if I changed note=n to ref=n all the other multi-selected ways already have ref=n (11 in this case) as well as note=m (for their value of m). In my case it was ways -33 and -37 which made me spot the problem, so I don't know whether it is only an issue with unsaved ways. If I'd used ref initially I probably wouldn't have noticed. I'm rating this as trivial as I don't map many golf courses, and this tag isn't rendered as far as I know (though I did like the green highlighting that P2 added).
@openstreetmap-trac openstreetmap-trac self-assigned this Jul 23, 2021
@openstreetmap-trac
Copy link
Author

Author: EdLoach
[Added to the original trac issue at 8.40am, Wednesday, 12th October 2011]

This morning I thought I'd try and create steps to reproduce. I created two ways with tags note=1 and note=2, multi-selected them and added the tag golf=hole and changed note to ref. Now both are tagged golf=hole ref=. If I then change to 11 on one of the ways it shows as also changed on the other (which wasn't selected when I made the change).

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 10.10am, Sunday, 4th March 2012]

I had trouble understanding this at first, but can reproduce it, so for the benefit of others:

  1. Create ways tagged "note=1" and "note=2"
  2. Multi-select both (ie, ctrl+click) [you'll see note=]
  3. Change "note" to "ref"
  4. When you press enter after "note", the focus shifts to the tag value, which contains the text ""
  5. Clicking away to deselect seems to cause the actual value "" to be stored on each way
  6. Select one way, and type a value instead of , say "11"
  7. The other way, even though it's not selected, also receives this new value.

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 11.49am, Sunday, 4th March 2012]

Fix trac formatting:

  1. Create ways tagged "note=1" and "note=2"
  2. Multi-select both (ie, ctrl+click) [you'll see note=]
  3. Change "note" to "ref"
  4. When you press enter after "note", the focus shifts to the tag value, which contains the text ""
  5. Clicking away to deselect seems to cause the actual value "" to be stored on each way
  6. Select one way, and type a value instead of , say "11"
  7. The other way, even though it's not selected, also receives this new value.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 6.22pm, Tuesday, 13th March 2012]

I'm halfway through solving this but it's not trivial! Hopefully have a patch before too long.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 11.15am, Friday, 16th March 2012]

Fixed in systemed/potlatch2@eaca14e . At least I hope so. Thanks for the clear steps-to-reproduce which helped enormously in nailing this down.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: potlatch2 Priority: trivial Resolution: fixed Type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac