Navigation Menu

Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Potlatch creating self overlapping roads #4264

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 10 comments
Closed

Potlatch creating self overlapping roads #4264

openstreetmap-trac opened this issue Jul 23, 2021 · 10 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Maetma
[Submitted to the original trac issue database at 8.30pm, Saturday, 3rd March 2012]

Many new users add roads that are superposed with Potlatch. Create this roads should be forbidden by Potlacth. It takes a lot of time to fix.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 9.05pm, Wednesday, 7th March 2012]

Not really a clearly expressed bug.

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 10.11pm, Wednesday, 7th March 2012]

My interpretation of this bug was that Potlatch should warn/prevent users making roads that cross each other ("superposed") without a junction. I've previously written the code to make this possible, so I actually think it's feasible.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 10.19pm, Wednesday, 7th March 2012]

There is actually a (slightly better phrased) dupe of this by the same reporter, so we don't need both. It's certainly possible code-wise, that much is fairly obvious. It's the UI that's harder - we certainly don't want P2 to start randomly adding junction nodes when the user's very next action might be to add a bridge=yes tag. I suspect a better solution might be the long-planned data quality inspector, but it needs careful design.

@openstreetmap-trac
Copy link
Author

Author: Maetma
[Added to the original trac issue at 4.30pm, Friday, 9th March 2012]

Examples:

http://www.openstreetmap.org/browse/changeset/10922002
http://www.openstreetmap.org/browse/changeset/10922023

@openstreetmap-trac
Copy link
Author

Author: Maetma
[Added to the original trac issue at 1.58pm, Friday, 27th April 2012]

In the case I am described the raod selfs overlapping.

In the majority of the cases the user clicks again on the before last node. The incorrect road is like this : node1 node2 node3 ... node(n-1) node(n) node(n-1)

He would not be possible to re-selecting node(n-1)

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 1.42pm, Sunday, 29th April 2012]

Makes sense to prevent the user forming a way as described: 0, 1, 2, 3, 4, 3... Such a way seems extremely unlikely to be valid.

@openstreetmap-trac
Copy link
Author

Author: maetma
[Added to the original trac issue at 6.35pm, Tuesday, 19th June 2012]

Way as 1-2-1 must not be created

When delete 2 it gets way with one node in it this is wrong

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 12.35am, Wednesday, 20th June 2012]

Is this definitely still happening? I did review this code recently. Do you have an example?

@openstreetmap-trac
Copy link
Author

Author: illya2400
[Added to the original trac issue at 7.23pm, Tuesday, 16th February 2016]

Here are some examples of ways that completely overlap themselves. In JOSM, the validation error is "way contains segment twice"

way 396166566
way 396189678
way 396185942

Ways were created by new user using Potlatch 2. The ways were created in February 2016, so this is still a major issue.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 12.37pm, Friday, 24th March 2017]

Duplicate of #4020.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant