Opened 7 years ago

Closed 7 years ago

#4278 closed defect (fixed)

landuse=recreation_ground appears in Potlatch2 with a solid green background

Reported by: SomeoneElse Owned by: potlatch-dev@…
Priority: minor Milestone:
Component: potlatch2 Version:
Keywords: Cc:

Description

This means that you can't see anything under it.

leisure=recreation_ground appears as a more transparent green - perhaps landuse=recreation_ground should do the same?

P2's simple view suggests "leisure=recreation_ground", but I've tended to use "landuse=" as the more popular tag:

http://taginfo.openstreetmap.org/search?q=recreation_ground#values

I've no particular view on which tag is "better".

FWIW, I spotted it here: http://www.openstreetmap.org/edit?editor=potlatch2&lat=53.228&lon=-1.4651&zoom=16

Change History (2)

comment:1 Changed 7 years ago by Richard

Yep, the latest changes to the stylesheet appear to have hbroken the parser - also what showed up the hanging bug. Wil look at it when I'm back on the Mac this evening.

comment:2 Changed 7 years ago by Richard

Resolution: fixed
Status: newclosed

Fixed in https://github.com/systemed/potlatch2/commit/4e72cd67a534fbdff55d941c421531d8f2776b88 , hopefully live soon.

FWIW the problem was https://github.com/systemed/potlatch2/commit/0282edd0af03b94ea0e86641de16543d85dacdcc - running "!=undefined" against a Number (line 59) doesn't work, you need to use isNaN instead. It works in the CSSCOLORS[colorStr] case because Object values aren't explicitly typed in AS3.

Note: See TracTickets for help on using tickets.