Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Weird behavior when changing tags (ie name_1=* to alt_name=*) #4307

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: compdude
[Submitted to the original trac issue database at 6.09pm, Saturday, 17th March 2012]

In Potlatch 2 when you are using the advanced view to edit tags for a particular way, there is something weird going on when you change the tag from one thing to something else.

So here is what was happening: In the text field where you define the name of the tag (the first column, not the second), I went ahead and changed something from "name_1=ABC" to "alt_name=ABC", and then hit enter. Instead of just changing the key to "alt_name=ABC" like normal, it instead changed it to "source=[blank value field]" where source is the tag listed after the "name_1" tag. Interestingly enough, if you then click the undo button, it will do what it's supposed to do and re-add the "alt_name=ABC" tag and everything will return to normal. I just noticed this today (March 17) when I was editing, and I'm not sure if this is also an issue with nodes.

At least there's a simple workaround for this bug, so it's not like it's urgent or anything. But it's still kind of annoying and may be harder for new users to figure out what's going on.

Finally, I am using Potlatch 2 in Firefox 10.0.2 on Windows XP service pack 3.

Hope this helps, and happy bug-fixing :) !

Thanks, Compdude

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 12.39am, Sunday, 18th March 2012]

Hmm, I can't reproduce. What's the exact sequence of mouse clicks and keypresses? Does it only happen with tag values that have a B in them (since B is the shortcut for adding a source...)?

@openstreetmap-trac
Copy link
Author

Author: compdude
[Added to the original trac issue at 10.21pm, Sunday, 18th March 2012]

Replying to [comment:1 stevage]:

Hmm, I can't reproduce. What's the exact sequence of mouse clicks and keypresses? Does it only happen with tag values that have a B in them (since B is the shortcut for adding a source...)?

I was just using the source tag as an example. What exactly was happening was that I was doing TIGER fixup and I changed a name_1 tag to alt_name. And it instead was replacing it was the tag listed after the name_1 tag, which in this case happened to be tiger:tlid, I think. It happened several times in my editing session.

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 11.59pm, Sunday, 18th March 2012]

Can you still reproduce it? If so, could you give a specific example of an object that this happens to, and a sequence of steps like:

  1. Click on object X with a name_1=foo tag
  2. Click on name_1 label
  3. ...

@openstreetmap-trac
Copy link
Author

Author: compdude
[Added to the original trac issue at 3.22am, Monday, 19th March 2012]

Replying to [comment:3 stevage]:

Can you still reproduce it? If so, could you give a specific example of an object that this happens to, and a sequence of steps like:

  1. Click on object X with a name_1=foo tag
  2. Click on name_1 label
  3. ...

I tried it again on the same computer just now having updated firefox to version 11 from version 10 (why do they have to update it so often?) and It seems to be working fine. Obviously nothing was wrong with FF after all :)

@openstreetmap-trac
Copy link
Author

Author: compdude
[Added to the original trac issue at 3.24am, Monday, 19th March 2012]

Replying to [comment:4 compdude]:

Replying to [comment:3 stevage]:

Can you still reproduce it? If so, could you give a specific example of an object that this happens to, and a sequence of steps like:

  1. Click on object X with a name_1=foo tag
  2. Click on name_1 label
  3. ...

I tried it again on the same computer just now having updated firefox to version 11 from version 10 (why do they have to update it so often?) and It seems to be working fine. Obviously nothing was wrong with FF after all :)
EDIT: Meant to say nothing was wrong with Potlatch, not firefox

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 8.55am, Monday, 19th March 2012]

The TagGrid tab/enter behaviour has been fixed up really recently (in the past three days) so I guess it's possible that you caught an un-updated version of Potlatch first time round.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant