Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

language prefix of wikipedia tag values not being displayed #4315

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: Tordanik
[Submitted to the original trac issue database at 9.00pm, Friday, 23rd March 2012]

To reproduce the problem, browse a feature with a "wikipedia = lg:article" tag on osm.org, such as [http://www.openstreetmap.org/browse/way/39224062]

The example is tagged "wikipedia = de:Stadthaus (Coburg)" in the data, but the website displays it as "wikipedia = Stadthaus (Coburg)". The value is correctly linked to an article in the German Wikipedia, though.

Expected behaviour would be to display "wikipedia = de:Stadthaus (Coburg)", and still link the value to the German Wikipedia article.

This also affects the history view.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 12.23am, Saturday, 24th March 2012]

It looks to me like this is deliberate, and it is behaving as designed, but I think it's your code anyway.

@openstreetmap-trac
Copy link
Author

Author: cquest
[Added to the original trac issue at 7.54am, Tuesday, 28th August 2012]

This current display is misleading. Second time I'm misleaded ;)

An any other tag, the wikipedia tag value should always be displayed exactly as it is (which is not the case currently), while the link should point to the right article (which is the case).

@openstreetmap-trac
Copy link
Author

Author: ppawel[at]fastmail.fm
[Added to the original trac issue at 6.26pm, Friday, 5th October 2012]

Opened openstreetmap/openstreetmap-website#119 pull request for this bug...

Also I found another bug: when the language prefix is not lowercase, the link to Wikipedia is not generated properly. Example:

http://www.openstreetmap.org/browse/relation/2317380

Should I open another bug and patch it or can we do it in this one?

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 6.34pm, Friday, 5th October 2012]

I'm inclined to take this unless Dan has some very good reason not to... Any comment Dan?

Feel free to add the other patch on the same branch anyway, and there's certainly no need for a trac ticket for it.

@openstreetmap-trac
Copy link
Author

Author: dankarran
[Added to the original trac issue at 11.36am, Saturday, 6th October 2012]

Happy for you guys to take this on - I don't have a dev environment set up at the moment.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 3.05pm, Sunday, 7th October 2012]

This does look sensible to me, so I've merged it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant