Opened 7 years ago

Closed 7 years ago

#4315 closed defect (fixed)

language prefix of wikipedia tag values not being displayed

Reported by: Tordanik Owned by: Dan Karran
Priority: minor Milestone:
Component: website Version:
Keywords: Cc:

Description

To reproduce the problem, browse a feature with a "wikipedia = lg:article" tag on osm.org, such as http://www.openstreetmap.org/browse/way/39224062

The example is tagged "wikipedia = de:Stadthaus (Coburg)" in the data, but the website displays it as "wikipedia = Stadthaus (Coburg)". The value is correctly linked to an article in the German Wikipedia, though.

Expected behaviour would be to display "wikipedia = de:Stadthaus (Coburg)", and still link the value to the German Wikipedia article.

This also affects the history view.

Change History (6)

comment:1 Changed 7 years ago by Tom Hughes

Owner: changed from rails-dev@… to Dan Karran
Status: newassigned

It looks to me like this is deliberate, and it is behaving as designed, but I think it's your code anyway.

comment:2 Changed 7 years ago by cquest

This current display is misleading. Second time I'm misleaded ;)

An any other tag, the wikipedia tag value should always be displayed exactly as it is (which is not the case currently), while the link should point to the right article (which is the case).

comment:3 Changed 7 years ago by ppawel@…

Opened https://github.com/openstreetmap/openstreetmap-website/pull/119 pull request for this bug...

Also I found another bug: when the language prefix is not lowercase, the link to Wikipedia is not generated properly. Example:

http://www.openstreetmap.org/browse/relation/2317380

Should I open another bug and patch it or can we do it in this one?

comment:4 Changed 7 years ago by Tom Hughes

I'm inclined to take this unless Dan has some very good reason not to... Any comment Dan?

Feel free to add the other patch on the same branch anyway, and there's certainly no need for a trac ticket for it.

comment:5 Changed 7 years ago by dankarran

Happy for you guys to take this on - I don't have a dev environment set up at the moment.

comment:6 Changed 7 years ago by Tom Hughes

Resolution: fixed
Status: assignedclosed

This does look sensible to me, so I've merged it.

Note: See TracTickets for help on using tickets.