Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Misspelled icon URL: dispensing instead of dispencing #4373

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Misspelled icon URL: dispensing instead of dispencing #4373

openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Assignees
@openstreetmap-trac
Labels
Component: nominatim Priority: minor Resolution: fixed Type: defect

Comments

@openstreetmap-trac
Copy link

Reporter: linuxminded[at]gmail.com
[Submitted to the original trac issue database at 11.33am, Sunday, 22nd April 2012]

The query for [http://nominatim.openstreetmap.org/search.php?q=Nederhorst+den+Berg%2C+The+Netherlands Nederhorst den Berg, The Netherlands] returns among its results a pharmacy ([http://nominatim.openstreetmap.org/details.php?place_id=8699915 place_id 8699915]) with a misspelled icon URL.

It lists:

http://nominatim.openstreetmap.org/images/mapicons/health_pharmacy_dispensing.p.20.png

instead of:

http://nominatim.openstreetmap.org/images/mapicons/health_pharmacy_dispencing.p.20.png

A simple work around is to use replace() on the icon property of the JSON object:

data[i].icon.replace(/dispensing/, 'dispencing');
@openstreetmap-trac openstreetmap-trac self-assigned this Jul 23, 2021
@openstreetmap-trac
Copy link
Author

Author: linuxminded[at]gmail.com
[Added to the original trac issue at 11.51pm, Sunday, 22nd April 2012]

Since dispensing is the proper spelling, fixing the images seems the correct approach.

I don't have a Github account to provide a fixed branch, but fixing the Nominatim git repo is easy:

for f in website/images/mapicons/health_pharmacy_dispencing.*;
do
    git mv $f $(echo $f | sed 's/dispencing/dispensing/g');
done
git commit -m 'Fix typo: health_pharmacy_dispencing -> health_pharmacy_dispensing'

@openstreetmap-trac
Copy link
Author

Author: lonvia
[Added to the original trac issue at 10.21pm, Thursday, 26th April 2012]

Fixed and deployed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: nominatim Priority: minor Resolution: fixed Type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac