Opened 7 years ago

Closed 7 years ago

#4458 closed defect (fixed)

Ask for confirmation before deleting "unknown" nodes or relation members

Reported by: ajank Owned by: potlatch-dev@…
Priority: minor Milestone:
Component: potlatch2 Version:
Keywords: unknown nodes, relations Cc:

Description

With the current Potlatch2 version, a novice user may easily consider a "not recognised" node as junk and delete it. Such "not recognised" nodes will always be present, since it is not possible for Potlatch to capture every tag used. However, these nodes should be clearly distinguishable as informative by novice users. I suggest Potlatch ask for confirmation before deleting a node that has has any tags.

The question could read: "This node is not recognised by Potlatch, but it holds some information, which could be displayed under the advanced properties. Are you sure you want to delete it?".

The same applies to deleting any objects that are members of a relation. A novice user may be completely unaware of the existence of relations. He/she may find it easier to draw a new way/node and delete the old one, instead of adjusting the old one, thus breaking the relations without any notice.

Potlatch could ask: "This way[or node] is a member of a relation [here the relation name, being a link to the 'Edit Relation' window]. Are you sure you want to delete it?". The relation should be labelled like in the "Edit Relation" window, with the respective icon.

Change History (3)

comment:1 Changed 7 years ago by Richard

I don't like this as a solution, I'm afraid. Generally anything that involves adding more modal "Are you sure?" dialogue boxes is a bad idea. There is extensive evidence that users just click whatever is necessary to get the dialogue out of the way.

It would be better to (a) make sure that more object types are recognised, or failing that (b) have some way of showing an appealing summary of the tags/memberships in simple view.

comment:2 Changed 7 years ago by stevage

c) Provide comprehensive feedback when you delete something. "Deleted object with tags: foo=unknown; blah=never_going_to_be_implemented"...

IMHO doing b) and c) is more important than a).

comment:3 Changed 7 years ago by Richard

Resolution: fixed
Status: newclosed

(b) is now done for tags, at least: https://github.com/systemed/potlatch2/commit/6df69becdd6990294c964b2e469c76631a3e312a . Relation memberships can come at some point in the future.

Note: See TracTickets for help on using tickets.