Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Ask for confirmation before deleting "unknown" nodes or relation members #4458

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: ajank
[Submitted to the original trac issue database at 9.52am, Monday, 25th June 2012]

With the current Potlatch2 version, a novice user may easily consider a "not recognised" node as junk and delete it. Such "not recognised" nodes will always be present, since it is not possible for Potlatch to capture every tag used. However, these nodes should be clearly distinguishable as informative by novice users. I suggest Potlatch ask for confirmation before deleting a node that has has any tags.

The question could read: "This node is not recognised by Potlatch, but it holds some information, which could be displayed under the advanced properties. Are you sure you want to delete it?".

The same applies to deleting any objects that are members of a relation. A novice user may be completely unaware of the existence of relations. He/she may find it easier to draw a new way/node and delete the old one, instead of adjusting the old one, thus breaking the relations without any notice.

Potlatch could ask: "This way[or node] is a member of a relation [here the relation name, being a link to the 'Edit Relation' window]. Are you sure you want to delete it?". The relation should be labelled like in the "Edit Relation" window, with the respective icon.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 6.10am, Wednesday, 27th June 2012]

I don't like this as a solution, I'm afraid. Generally anything that involves adding more modal "Are you sure?" dialogue boxes is a bad idea. There is extensive evidence that users just click whatever is necessary to get the dialogue out of the way.

It would be better to (a) make sure that more object types are recognised, or failing that (b) have some way of showing an appealing summary of the tags/memberships in simple view.

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 7.34am, Wednesday, 27th June 2012]

c) Provide comprehensive feedback when you delete something. "Deleted object with tags: foo=unknown; blah=never_going_to_be_implemented"...

IMHO doing b) and c) is more important than a).

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 2.25pm, Saturday, 30th June 2012]

(b) is now done for tags, at least: systemed/potlatch2@6df69be . Relation memberships can come at some point in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant