Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Potlatch 2 can leave isolated nodes #4496

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

Potlatch 2 can leave isolated nodes #4496

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Madryn
[Submitted to the original trac issue database at 10.20am, Friday, 27th July 2012]

My understanding is that, when a way is deleted, all of its nodes are deleted unless they are part of other ways or are tagged with further information. That rule appears to be followed even if the only tag on a node is 'odbl=clean'. I deleted a way (a short footpath) that contained several nodes marked odbl=clean. After deleting the way, several isolated nodes remained, each tagged with 'odbl=clean' and no other tags. It would be easy to fail to notice these nodes and to leave them in place, thus increasing the size of the database without adding anything to the map.
I was using the default editor (Potlatch 2 in-browser) running on Firefox under Windows XP.

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 8.42am, Friday, 3rd August 2012]

Just to check I've understood, you're saying that when the user deletes a way in Potlatch2, any nodes that only contain an "odbl=clean" tag and nothing else should also be deleted?

If so, this sounds like the kind of mass automation task that is likely to be run at some point in the future anyway, I'm guessing?

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 8.45am, Friday, 3rd August 2012]

I think this is just a matter of adding 'odbl' to the key lists in hasInterestingTags in Entity.as and EntityCollection.as.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 8.48am, Friday, 3rd August 2012]

Fixed: systemed/potlatch2@cfc1379

@openstreetmap-trac
Copy link
Author

Author: Madryn
[Added to the original trac issue at 9.37pm, Friday, 3rd August 2012]

Replying to [comment:1 stevage]:

Just to check I've understood, you're saying that when the user deletes a way in Potlatch2, any nodes that only contain an "odbl=clean" tag and nothing else should also be deleted?

If so, this sounds like the kind of mass automation task that is likely to be run at some point in the future anyway, I'm guessing?

Thank you, that's exactly what I meant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant