You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.
Reporter: Schuyler Erle [Submitted to the original trac issue database at 6.39pm, Thursday, 30th August 2012]
Some combination of r7371 and r28156 added the removal of unused tags from the keyval structure passed to pgsql_filter_tags(), but this has the unwanted effect of removing tags that would otherwise be stored in an hstore column via the --hstore-column option before pgsql_out_*() get to write them.
This comment at line 772 of output-pgsql.c is telling:
/* We used to only go far enough to determine if it's a polygon or not,
but now we go through and filter stuff we don't need */
I think this change was made without regard to --hstore-column by accident.
The attached patch updates pgsql_filter_tags() to retain tags with a prefix matching any --hstore-column. The feature is only retained if --hstore-match-only is set, as with the normal --hstore option. This should restore the expected behavior of --hstore-column.
The text was updated successfully, but these errors were encountered:
Reporter: Schuyler Erle
[Submitted to the original trac issue database at 6.39pm, Thursday, 30th August 2012]
Some combination of r7371 and r28156 added the removal of unused tags from the
keyval
structure passed topgsql_filter_tags()
, but this has the unwanted effect of removing tags that would otherwise be stored in an hstore column via the --hstore-column option beforepgsql_out_*()
get to write them.This comment at line 772 of
output-pgsql.c
is telling:I think this change was made without regard to --hstore-column by accident.
The attached patch updates
pgsql_filter_tags()
to retain tags with a prefix matching any --hstore-column. The feature is only retained if --hstore-match-only is set, as with the normal --hstore option. This should restore the expected behavior of --hstore-column.The text was updated successfully, but these errors were encountered: