Opened 7 years ago

Closed 7 years ago

#4586 closed defect (invalid)

Weekly changeset dump incorrectly flagging all changesets as closed

Reported by: ToeBee Owned by: rails-dev@…
Priority: minor Milestone:
Component: api Version:
Keywords: Cc: toby.murray@…

Description

Not really a core map API problem but I don't see a more fitting component in trac.

All changesets in the weekly changeset dump file are marked as being closed even if they are still open at the time of the dump.

After talking about it in #osm-dev, TomH determined that it is because the now() function in the SQL on line 235 of planet06_pg.cpp returns server local time whereas the closed_at column is stored in UTC. Since closed_at is set to one hour in the future every time a changeset is updated, that comparison will always return false.

A possible fix is to change "now()" to "now() at time zone 'utc' "

Change History (1)

comment:1 Changed 7 years ago by Tom Hughes

Resolution: invalid
Status: newclosed

As you yourself said, this is not an API problem.

Best approach is probably to raise an issue, or better still a pull request, on github.

Note: See TracTickets for help on using tickets.