Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Weekly changeset dump incorrectly flagging all changesets as closed #4586

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 1 comment
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: ToeBee
[Submitted to the original trac issue database at 12.44pm, Friday, 21st September 2012]

Not really a core map API problem but I don't see a more fitting component in trac.

All changesets in the weekly changeset dump file are marked as being closed even if they are still open at the time of the dump.

After talking about it in #osm-dev, TomH determined that it is because the now() function in the SQL on line 235 of [http://git.openstreetmap.org/planetdump.git/blob/HEAD:/planet06_pg.cpp#l235 planet06_pg.cpp] returns server local time whereas the closed_at column is stored in UTC. Since closed_at is set to one hour in the future every time a changeset is updated, that comparison will always return false.

A possible fix is to change "now()" to "now() at time zone 'utc' "

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 9.31pm, Friday, 21st September 2012]

As you yourself said, this is not an API problem.

Best approach is probably to raise an issue, or better still a pull request, on github.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant